Closed Bug 1717489 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29448 - Properly disallow custom layout + multicol, attempt 2.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29448 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29448
Details from upstream follow.

b'Morten Stenshorne <mstensho@chromium.org>' wrote:

Properly disallow custom layout + multicol, attempt 2.

CL:2964675 wasn't enough for fieldsets that attempted both multicol and
custom layout, since the column properties are inherited by the
anonymous fieldset contents wrapper (while custom layout isn't
inherited).

Move checks from CreateOrDestroyMultiColumnFlowThreadIfNeeded() to a
separate method, so that the fieldset code can call it and make sure
that we don't let the anonymous wrapper inherit column properties in
custom layout.

Also add a DCHECK to catch any remaining bugs like this earlier (when
building the layout tree, rather than in paint).

Bug: 1221885
Change-Id: Ibdf07cea4932e165fd15ccf131c1ab06984d7dd2
Reviewed-on: https://chromium-review.googlesource.com/2975442
WPT-Export-Revision: 1de75a664fc603ea355d564c956b5b9d42fc63d6

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49a984f39b14
[wpt PR 29448] - Properly disallow custom layout + multicol, attempt 2., a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.