[wpt-sync] Sync PR 29448 - Properly disallow custom layout + multicol, attempt 2.
Categories
(Core :: Layout, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 29448 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/29448
Details from upstream follow.
b'Morten Stenshorne <mstensho@chromium.org>' wrote:
Properly disallow custom layout + multicol, attempt 2.
CL:2964675 wasn't enough for fieldsets that attempted both multicol and
custom layout, since the column properties are inherited by the
anonymous fieldset contents wrapper (while custom layout isn't
inherited).Move checks from CreateOrDestroyMultiColumnFlowThreadIfNeeded() to a
separate method, so that the fieldset code can call it and make sure
that we don't let the anonymous wrapper inherit column properties in
custom layout.Also add a DCHECK to catch any remaining bugs like this earlier (when
building the layout tree, rather than in paint).Bug: 1221885
Change-Id: Ibdf07cea4932e165fd15ccf131c1ab06984d7dd2
Reviewed-on: https://chromium-review.googlesource.com/2975442
WPT-Export-Revision: 1de75a664fc603ea355d564c956b5b9d42fc63d6
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c55e576a9305546ae446c2ce47f3e315bdb8d1c
Assignee | ||
Comment 2•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6248df1cc973e911de6e6cb29310d9a6d0bd14a0
Assignee | ||
Comment 3•3 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS : 1
Chrome
CRASH: 1
Safari
PASS : 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/49a984f39b14 [wpt PR 29448] - Properly disallow custom layout + multicol, attempt 2., a=testonly
Comment 5•3 years ago
|
||
bugherder |
Description
•