1717580 - Actor/Front isDestroyed should not return true for uninitialized objects

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

At the moment, Actor/Front isDestroyed is implemented as return this.actorID === null;

However this will be true both when the object is destroyed and when it is unitialized (before it got managed by a Pool and assigned an actorID).

This will be problematic in cases where we need to differentiate between destroyed and unitialized objects.

For instance, at the moment the protocol might attempt to write responses containing destroyed actors, which is actually invalid and should be fixed. However since the protocol is also responsible for initializing actors, it cannot simply reject Actors with a missing actorID.

Instead we should have a real _isDestroyed state and only use this.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1717580 - [devtools] Actor/Front isDestroyed should not return true for uninitialized objects

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f57b43635a45
[devtools] Actor/Front isDestroyed should not return true for uninitialized objects r=ochameau

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f57b43635a45