1717606 - Some follow-up changes for bug 1715512

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1717606 part 1 - Inline Shape::setObjectFlag in JSObject::setFlag. r?jonco!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1717606 part 2 - Inline Shape::setProto in JSObject::setProtoUnchecked. r?jonco!

Depends on D118459

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1717606 part 3 - Make replaceShape set the object's shape. r?jonco!

This simplifies the callers. Eventually replaceShape could be moved to SharedShape.

Depends on D118460

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1717606 part 4 - Remove setFlag's GenerateShape argument. r?jonco!

This was a footgun because the argument defaults to GENERATE_NONE, meaning it can change
a dictionary shape's object flags without allocating a new shape.

We don't rely on this anywhere for perf reasons so it's simpler and safer to always
allocate a new shape.

Depends on D118461

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1717606 part 5 - Remove NativeObject::clearFlag. r?jonco!

It's better to clear the Indexed flag in densifySparseElements directly, so that
we don't need to immediately allocate a new shape.

Depends on D118462

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1717606 part 6 - Remove NativeObject::lastProperty. r?jonco!

The lastProperty name no longer makes sense for the shape now that properties
are stored separately.

Depends on D118463

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2139ba84a1fe
part 1 - Inline Shape::setObjectFlag in JSObject::setFlag. r=jonco
https://hg.mozilla.org/integration/autoland/rev/2bd82ca65e09
part 2 - Inline Shape::setProto in JSObject::setProtoUnchecked. r=jonco
https://hg.mozilla.org/integration/autoland/rev/b074f6287b26
part 3 - Make replaceShape set the object's shape. r=jonco
https://hg.mozilla.org/integration/autoland/rev/a78b62f28c6a
part 4 - Remove setFlag's GenerateShape argument. r=jonco
https://hg.mozilla.org/integration/autoland/rev/bb1dcb7d3777
part 5 - Remove NativeObject::clearFlag. r=jonco
https://hg.mozilla.org/integration/autoland/rev/7a0639221c99
part 6 - Remove NativeObject::lastProperty. r=jonco

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2139ba84a1fe
https://hg.mozilla.org/mozilla-central/rev/2bd82ca65e09
https://hg.mozilla.org/mozilla-central/rev/b074f6287b26
https://hg.mozilla.org/mozilla-central/rev/a78b62f28c6a
https://hg.mozilla.org/mozilla-central/rev/bb1dcb7d3777
https://hg.mozilla.org/mozilla-central/rev/7a0639221c99