1717651 - Remove "ensure_subprocess_env()"

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task)

Description

[Mitchell Hentges [:mhentges] 🦀]

Now that Mach always runs with Python 3, we should no longer need ensure_subprocess_env().

You can see the two definitions here (ignore the xpcshell one for now), and you can see all usages here.

Note that this may require some digging to ensure that inputs that are currently cleaned up with ensure_subprocess_env() are instead being properly cleaned up (or are already clean) earlier in the process.

Comment 1

[Surajeet Das]

Attachment: Bug 1717651 - Removed instances of 'ensure_subprocess_env()' from virtualenv.py r=mhentges

Since Python 2 is no longer used in virtualenv.py ,hence 'ensure_subprocess_env()' is obsolete.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13fbb4213ba3
Removed instances of 'ensure_subprocess_env()' from virtualenv.py r=mhentges

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/13fbb4213ba3

Comment 4

[Surajeet Das]

Attachment: Bug 1717651 - Removed instances of 'ensure_subprocess_env' from python/mach r=mhentges

Since Python 2 is no longer used in python/mach, hence 'ensure_subprocess_env' is obsolete .

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f74deeb960bd
Removed instances of 'ensure_subprocess_env' from python/mach r=mhentges

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f74deeb960bd

Comment 7

[Surajeet Das]

Attachment: Bug 1717651 - Removed instances of 'ensure_subprocess_env' from python/mozbuild r=mhentges

Since Python 2 is no longer used in python/mozbuild, 'ensure_subprocess_env' is obsolete .

Comment 8

[Surajeet Das]

Attachment: Bug 1717651 - Removed instances of 'ensure_subprocess_env' from python/mozbuild r=mhentges

Since Python 2 is no longer used in python/mozbuild, hence 'ensure_subprocess_env' is obsolete.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/912db2ad9575
Removed instances of 'ensure_subprocess_env' from python/mozbuild r=mhentges

Comment 10

[Surajeet Das]

Attachment: Bug 1717651 - Removed instances of 'ensure_subprocess_env' from python/mozperftest r=mhentges

Since Python 2 is no longer used in python/mozperftest, hence 'ensure_subprocess_env' is obsolete.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1fb684b26c1
Removed instances of 'ensure_subprocess_env' from python/mozperftest r=mhentges

Comment 12

[Surajeet Das]

Attachment: Bug 1717651 - Removed instances of 'ensure_subprocess_env' from python/mozversioncontrol r=mhentges

Since Python 2 is no longer used in python/mozversioncontrol, hence 'ensure_subprocess_env' is obsolete.

Comment 13

[Surajeet Das]

Attachment: Bug 1717651 - Removed instances of 'ensure_subprocess_env' from tools/lint/eslint r=mhentges

Since Python 2 is no longer used in tools/lint/eslint,hence 'ensure_subprocess_env' is obsolete.

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/912db2ad9575
https://hg.mozilla.org/mozilla-central/rev/a1fb684b26c1

Comment 15

[Surajeet Das]

Attachment: Bug 1717651 - Removed instances of 'ensure_subprocess_env' from tools/tryselect/selectors r=mhentges

'ensure_subprocess_env' is obsolete now as Python 2 is no longer used in tools/tryselect/selectors .

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09f3f41ede3e
Removed instances of 'ensure_subprocess_env' from python/mozversioncontrol r=mhentges

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf8fd1ef8974
Removed instances of 'ensure_subprocess_env' from tools/tryselect/selectors r=mhentges

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/09f3f41ede3e
https://hg.mozilla.org/mozilla-central/rev/cf8fd1ef8974

Comment 19

[Surajeet Das]

Attachment: Bug 1717651 - Removed 'ensure_subprocess_env()' from mozbuild/util.py r=mhentges

'ensure_subprocess_env()' is obsolete as Python 2 is no longer used in python/mozbuild .

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a4fa947b58f
Removed instances of 'ensure_subprocess_env' from tools/lint/eslint r=mhentges

Comment 21

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2a4fa947b58f

Comment 22

[Surajeet Das]

Attachment: Bug 1717651 - Removed instances of 'ensure_subprocess_env' from testing/xpcshell r=mhentges

Since Python 2 is no longer used in testing/xpcshell, therefore 'ensure_subprocess_env' is obsolete.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af4c8799d2e8
Removed 'ensure_subprocess_env()' from mozbuild/util.py r=mhentges

Comment 24

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/af4c8799d2e8

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0969515dee19
Removed instances of 'ensure_subprocess_env' from testing/xpcshell r=mhentges

Comment 26

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0969515dee19

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/c951fdde8419