Closed Bug 1717668 Opened 3 years ago Closed 3 years ago

[XFA] A specific PDF file is not loaded / displayed

Categories

(Firefox :: PDF Viewer, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox-esr78 --- unaffected
firefox89 --- disabled
firefox90 --- unaffected
firefox91 --- fixed
firefox92 --- verified

People

(Reporter: danibodea, Assigned: calixte)

References

(Regression)

Details

(Keywords: regression)

Attachments

(8 files)

Note

  • When the user loads a specific PDF, he will notice that the file will not load.

Affected versions

  • Nightly v91.0a1

Affected platforms

  • all

Steps to reproduce

  1. Launch browser.
  2. Flip the pdfjs.enableXfa to true.
  3. Load the attached PDF file.

Expected result

  • The file is loaded and displayed.

Actual result

  • The file is NOT loaded and displayed.

Regression range

  • This is a regression of bug 1717132; mozregression results:

    2021-06-22T19:52:53.047000: DEBUG : Found commit message:
    Bug 1717132 - Update pdf.js to version 2.10.146 r=marco

    Differential Revision: https://phabricator.services.mozilla.com/D118240

    2021-06-22T19:52:53.047000: DEBUG : Did not find a branch, checking all integration branches
    2021-06-22T19:52:53.049000: INFO : The bisection is done.
    2021-06-22T19:52:53.050000: INFO : Stopped

Priority: -- → P1
Summary: [XFA] Some images are not being displayed → [XFA] A specific PDF file is not loaded / displayed
Priority: -- → P1

I've tried removing the priority, but it appears to fail. Please set the corresponding priority.

Assignee: nobody → cdenizet
Status: NEW → ASSIGNED
Regressed by: 1717132
Has Regression Range: --- → yes

This issue also occurs in the case of the attached PDF.
It is also loaded in the latest Beta v90.0b11, but not properly displayed.

Left a note here to check when this bug has a fix.

Another PDF with the same behavior. This one is also not loaded in Beta v90.0b11.

Depends on: 1718101
No longer blocks: 1716838

The first is fixed, the other two PDFs are still failing to load.

(In reply to Marco Castelluccio [:marco] from comment #6)

The first is fixed, the other two PDFs are still failing to load.

I confirm this on all platforms.

This issue also occurs in the case of the attached PDF.

Attached file PDFIUM-292-0.pdf

A different PDF that won't load was discovered.
Please let us know if you want them logged sepparately.

Depends on: 1719380

About PDFIUM-292-0.pdf: during binding process some nodes are identified thanks to SOM expressions (a kind of XPath) and those expressions can can contain some JS code, for example:

 $.COMMAND.sendApplicationInformationRequest.prospectApplication.prospectParty.(typeName.value== "additionalInsured")

In this expression the sub-expression between parenthesis is a JS expression and for now embedded JS is not evaluated.
So in this case we should smartly fail and skip the current binding.

About sumatrapdf-1546-0-GOOD.pdf, it's working ok with upstream pdf.js on master: I'd say it has been fixed thanks to:
https://github.com/mozilla/pdf.js/commit/5f76b6370c91d7a4358edffb9caac667af9dd680

About 08ba1dad-3244-4854-b0a9-00347e016306.pdf and 8cf6c672-3cad-4733-80c4-0f2e848b5ebf.pdf , they've been fixed few days ago and they're in pdf.js test suite.

Can you verify all PDFs from this bug, except PDFIUM-292-0.pdf, are fixed?

Flags: needinfo?(daniel.bodea)

(In reply to Marco Castelluccio [:marco] from comment #13)

Can you verify all PDFs from this bug, except PDFIUM-292-0.pdf, are fixed?

Yes, I can confirm that. All PDFs reported are being fixed except the last one.
We can keep this bug open for the last PDF or we can close it and open a clone for the remaining issue.
Which one is preferable?

Testing Results:

  • 2ee7f078-0324-4012-b4b1-6a4925cc17f5.pdf - fixed; loads and displays.
  • 08ba1dad-3244-4854-b0a9-00347e016306.pdf - partially fixed; loads and displays a first page, but does not work properly.
  • 8cf6c672-3cad-4733-80c4-0f2e848b5ebf.pdf - partially fixed; loads and displays a first page, but does not work properly.
  • sumatrapdf-1546-0-GOOD.pdf - partially fixed; loads and displays a first page, but does not work properly.
  • PDFIUM-292-0.pdf - NOT fixed; still does not load!
QA Whiteboard: [pdf_xfa_generic]
Flags: needinfo?(daniel.bodea) → needinfo?(cdenizet)

08... & 8c... are dynamic so from a static pov, I'd say they're fixed but we can open a new bug for the JS part.
About sumatra... could you elaborate ?
And about PDFIUM... I've a WIP locally.

Flags: needinfo?(cdenizet)
Flags: needinfo?(daniel.bodea)

The issue for the PDFIUM... file has been addressed in:
https://github.com/mozilla/pdf.js/pull/13687

Depends on: 1720361
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

(In reply to Calixte Denizet (:calixte) from comment #15)

08... & 8c... are dynamic so from a static pov, I'd say they're fixed but we can open a new bug for the JS part.
About sumatra... could you elaborate ?
And about PDFIUM... I've a WIP locally.

I've logged new bugs for the remaining issues:

  • 2ee7f078-0324-4012-b4b1-6a4925cc17f5.pdf
    ** fixed; loads and displays correctly;
    ** remaining static field issues found: bug 1720660, bug 1720664.
  • 08ba1dad-3244-4854-b0a9-00347e016306.pdf
    ** static issue fixed and verified;
    ** dynamic issue remaining: bug 1720665.
  • 8cf6c672-3cad-4733-80c4-0f2e848b5ebf.pdf - partially fixed; loads and displays a first page, but does not work properly.
    ** static issue fixed and verified;
    ** dynamic issue remaining: bug 1720665.
  • sumatrapdf-1546-0-GOOD.pdf
    ** static issue fixed and verified;
    ** dynamic issue remaining: bug 1720667.
  • PDFIUM-292-0.pdf - NOT fixed; still does not load!
    ** static issue fixed and verified;
    ** dynamic issue remaining: bug 1720667.

Closing this report as verified.

Status: RESOLVED → VERIFIED
Flags: needinfo?(daniel.bodea)

Fixed in beta by the uplift in bug 1720361.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: