1717765 - Fission? Crash in [@ nsGlobalWindowInner::FreezeInternal]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Pascal Chevrel (relman team) -> :pascalc]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/9add03de-0a98-4079-b1ce-790bc0210622

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(IsCurrentInnerWindow())

Top 10 frames of crashing thread:

0 xul.dll nsGlobalWindowInner::FreezeInternal dom/base/nsGlobalWindowInner.cpp:5607
1 xul.dll nsGlobalWindowInner::SyncStateFromParentWindow dom/base/nsGlobalWindowInner.cpp:5716
2 xul.dll nsGlobalWindowOuter::SetNewDocument dom/base/nsGlobalWindowOuter.cpp:2380
3 xul.dll nsDocumentViewer::InitInternal layout/base/nsDocumentViewer.cpp:900
4 xul.dll nsDocumentViewer::Init layout/base/nsDocumentViewer.cpp:682
5 xul.dll nsDocShell::Embed docshell/base/nsDocShell.cpp:5624
6 xul.dll nsDocShell::CreateContentViewer docshell/base/nsDocShell.cpp:7919
7 xul.dll nsDSURIContentListener::DoContent docshell/base/nsDSURIContentListener.cpp:179
8 xul.dll nsDocumentOpenInfo::TryContentListener uriloader/base/nsURILoader.cpp:596
9 xul.dll nsDocumentOpenInfo::OnStartRequest uriloader/base/nsURILoader.cpp:154

Comment 1

[Chris Peterson [:cpeterson]]

In the last three months, 72 out of 72 crashes have Fission enabled.

There are some crash reports from Nightly 90 and Beta 90.0b0 (maybe someone in the Fission Beta 90 experiment?), but most of the crashes are from Nightly 91. Seems like something changed recently that caused the crashes to spike in Nightly 91.

Comment 2

[Intermittent Failures Robot]

1 failures in 723 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1717765&startday=2021-06-28&endday=2021-07-04&tree=all

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

This is most probably bfcache related.
I'll try to figure out some way to prevent this issue.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1717765, tweak the check when creating a new content viewer shouldn't succeed, r=peterv

The patch is based on the assumption that the assertion fails because of
https://searchfox.org/mozilla-central/rev/1c5c3f4ec274462b92cf5bd82235ae3a56c508e9/dom/base/nsGlobalWindowInner.cpp#2775

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f282075686a5
tweak the check when creating a new content viewer shouldn't succeed, r=peterv

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f282075686a5