Closed Bug 1717786 Opened 3 years ago Closed 3 years ago

Permanent perftest ModuleNotFoundError: No module named 'attr'

Categories

(Testing :: mozperftest, defect, P5)

defect

Tracking

(firefox-esr78 unaffected, firefox-esr91 unaffected, firefox89 unaffected, firefox90 unaffected, firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox89 --- unaffected
firefox90 --- unaffected
firefox91 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mhentges)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=343576498&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/JsY-k9G2RXqoYyvacsFc-A/runs/0/artifacts/public/logs/live_backing.log


[task 2021-06-23T04:36:11.858Z] script.py: running command 'bash -cx mkdir -p $MOZ_FETCHES_DIR/../artifacts && cd $GECKO_PATH && python3 python/mozperftest/mozperftest/runner.py --flavor mobile-browser --android --android-clear-logcat --android-capture-logcat logcat --android-app-name org.mozilla.geckoview_example --android-activity org.mozilla.geckoview_example.GeckoViewActivity --android-perf-tuning --perfherder-metrics processLaunchToNavStart --android-install-apk gve_nightly_aarch64 --hooks testing/performance/hooks_android_view.py --perfherder --perfherder-app geckoview --browsertime-geckodriver ${MOZ_FETCHES_DIR}/geckodriver --browsertime-iterations 14 --output $MOZ_FETCHES_DIR/../artifacts testing/performance/perftest_android_view.js'
[task 2021-06-23T04:36:11.858Z] + mkdir -p /builds/task_162442264098509/fetches/../artifacts
[task 2021-06-23T04:36:11.858Z] + cd /builds/task_162442264098509/checkouts/gecko
[task 2021-06-23T04:36:11.858Z] + python3 python/mozperftest/mozperftest/runner.py --flavor mobile-browser --android --android-clear-logcat --android-capture-logcat logcat --android-app-name org.mozilla.geckoview_example --android-activity org.mozilla.geckoview_example.GeckoViewActivity --android-perf-tuning --perfherder-metrics processLaunchToNavStart --android-install-apk gve_nightly_aarch64 --hooks testing/performance/hooks_android_view.py --perfherder --perfherder-app geckoview --browsertime-geckodriver /builds/task_162442264098509/fetches/geckodriver --browsertime-iterations 14 --output /builds/task_162442264098509/fetches/../artifacts testing/performance/perftest_android_view.js
[task 2021-06-23T04:36:11.858Z] Traceback (most recent call last):
[task 2021-06-23T04:36:11.858Z]   File "python/mozperftest/mozperftest/runner.py", line 225, in <module>
[task 2021-06-23T04:36:11.858Z]     sys.exit(main())
[task 2021-06-23T04:36:11.858Z]   File "python/mozperftest/mozperftest/runner.py", line 184, in main
[task 2021-06-23T04:36:11.858Z]     from mozperftest import PerftestArgumentParser
[task 2021-06-23T04:36:11.858Z]   File "/builds/task_162442264098509/checkouts/gecko/python/mozperftest/mozperftest/__init__.py", line 6, in <module>
[task 2021-06-23T04:36:11.858Z]     from mozperftest.argparser import PerftestArgumentParser  # noqa
[task 2021-06-23T04:36:11.858Z]   File "/builds/task_162442264098509/checkouts/gecko/python/mozperftest/mozperftest/argparser.py", line 20, in <module>
[task 2021-06-23T04:36:11.858Z]     from mozperftest.metrics import get_layers as metrics_layers  # noqa
[task 2021-06-23T04:36:11.858Z]   File "/builds/task_162442264098509/checkouts/gecko/python/mozperftest/mozperftest/metrics/__init__.py", line 5, in <module>
[task 2021-06-23T04:36:11.858Z]     from mozperftest.metrics.perfherder import Perfherder
[task 2021-06-23T04:36:11.858Z]   File "/builds/task_162442264098509/checkouts/gecko/python/mozperftest/mozperftest/metrics/perfherder.py", line 5, in <module>
[task 2021-06-23T04:36:11.858Z]     import jsonschema
[task 2021-06-23T04:36:11.858Z]   File "/builds/task_162442264098509/checkouts/gecko/third_party/python/jsonschema/jsonschema/__init__.py", line 11, in <module>
[task 2021-06-23T04:36:11.858Z]     from jsonschema.exceptions import (
[task 2021-06-23T04:36:11.858Z]   File "/builds/task_162442264098509/checkouts/gecko/third_party/python/jsonschema/jsonschema/exceptions.py", line 9, in <module>
[task 2021-06-23T04:36:11.858Z]     import attr
[task 2021-06-23T04:36:11.858Z] ModuleNotFoundError: No module named 'attr'
[task 2021-06-23T04:36:11.858Z] script.py: command finished

Android perftest tasks fail permanently with this failure if they don't hit the intermittent internal server error issue. Last successful run was on June 16th.

Flags: needinfo?(gmierz2)

The linux perftest runs fail for the same reason, the Windows ones complain about urrlib3 being missing.

Summary: Permanent Android perftest ModuleNotFoundError: No module named 'attr' → Permanent perftest ModuleNotFoundError: No module named 'attr'
Blocks: 1715478

I'll take a look at this tomorrow, thanks for identifying the regressing bug :)

Flags: needinfo?(mhentges)

@sparky this perma should fail our unit tests. But they are passing.
passing unit test from 22 june: https://treeherder.mozilla.org/jobs?repo=autoland&tier=1%2C2%2C3&revision=97ce4ca4f50b990efec64fd0e76645f9ca46df9c&searchStr=mpu&selectedTaskRun=X--xody7Q5-rMn3boLJ_7g.0

Can we check why we did not catch this in the unit tests?

The unit tests didn't catch this because it's a bug in top-level mozperftest/runner.py - it has an out-of-date list of in-tree Python packages.
Meanwhile, while running ./mach python-test ..., Mach is handling the package list instead, and its list is up-to-date. Patch incoming.

Flags: needinfo?(mhentges)

After replacing a bunch of vendored source packages with wheels, the
paths to the raw source changed.

Assignee: nobody → mhentges
Status: NEW → ASSIGNED
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b5404b7f0c9 Update mozperfest runner's list of in-tree Python packages r=kimberlythegeek
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Flags: needinfo?(gmierz2)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: