1717807 - The Debugger tab should be properly unhighlighted

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Prefs:

• fission.autostart => true
• devtools.target-switching.server.enabled => true
• fission.bfcacheInParent => true

STRs:

1. Load http://janodvarko.cz/tests/fission/case1/index.html
2. Create BP in janodvarko.cz/index.js file, line 3
3. Reload the page to hit the BP, the Debugger tab is highlighted => OK
4. Load different page, e.g. http://janodvarko.cz/firebug/tests/601/Issue601.htm
5. The Debugger tab is still highlighted even if the Debugger isn't paused anymore => ERR

The Toolbox needs to be reopened to get rid of the highlighted Debugger tab
I don't see the behavior on pages with no remote frame.

Honza

Comment 1

[Hubert Boma Manilla (:bomsy)]

The STR above on it's own does not reproduce for me.

In addition, i need to go back and forward between the two pages to see the Debugger tab still highlighted
when on http://janodvarko.cz/firebug/tests/601/Issue601.htm.

So my STR

Prefs:

• fission.autostart => true
• devtools.target-switching.server.enabled => true
• fission.bfcacheInParent => true

1. Load http://janodvarko.cz/tests/fission/case1/index.html
2. Create BP in janodvarko.cz/index.js file, line 3
3. Load different page, e.g. http://janodvarko.cz/firebug/tests/601/Issue601.htm in same tab
4. Go back to http://janodvarko.cz/tests/fission/case1/index.html page using the BACK BUTTON
5. Reload the page to hit the BP, the Debugger tab is highlighted => OK
6. Press the FORWARD BUTTON to go http://janodvarko.cz/firebug/tests/601/Issue601.htm page

AR
The Debugger Tab is still highlighted

ER
The Debugger Tab should not be highlighted

Honza, i wonder if you see this

Comment 2

[Hubert Boma Manilla (:bomsy)]

Extra note:
This looks like a BF Cache related issue as with the fission.bfcacheInParent => false, it works fine

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, I can repro the issue using your steps.

Also, after step #6 I am seeing the following error (system console) when trying to resume JS execution
JavaScript error: resource://devtools/client/debugger/src/client/firefox/commands.js, line 82: Error: Unknown thread front: server0.conn0.windowGlobal6442450952/thread21

Looks like BF Cache related. Note that sometimes - instead of pressing the Forward button in step #6 - load the http://janodvarko.cz/firebug/tests/601/Issue601.htm, and the problem is there too.

Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Another steps (without involving BFCache)

1. The same prefs ON as before
   1.5) Patches from Bug 1713607 applied.
2. Load http://janodvarko.cz/tests/fission/case9/index.html (two iframes loaded from the same remote domain),
3. Create BP in odvarko.com/tests/fission/case9/iframe1.js, line 6
4. Create BP in odvarko.com/tests/fission/case9/iframe2.js, line 6
5. Click the the POST1 button (in the first frame), Debugger should pause, step over one time
6. Click the the POST2 button (in the second frame), Debugger should pause in the second frame, step over one time & resume
7. Switch to the Test Frame #1 thread and resume.
8. The Debugger tab is still highlighted =>BUG

I think that switching the contexts through the Threads panel should be involved. So, if the steps above don't work for you. Try to play a bit with the UI (context switching, stepping) before resuming both.

Honza

Comment 5

[Hubert Boma Manilla (:bomsy)]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #4)

Another steps (without involving BFCache)

1. The same prefs ON as before
   1.5) Patches from Bug 1713607 applied.
2. Load http://janodvarko.cz/tests/fission/case9/index.html (two iframes loaded from the same remote domain),
3. Create BP in odvarko.com/tests/fission/case9/iframe1.js, line 6
4. Create BP in odvarko.com/tests/fission/case9/iframe2.js, line 6
5. Click the the POST1 button (in the first frame), Debugger should pause, step over one time
6. Click the the POST2 button (in the second frame), Debugger should pause in the second frame, step over one time & resume
7. Switch to the Test Frame #1 thread and resume.
8. The Debugger tab is still highlighted =>BUG

I think that switching the contexts through the Threads panel should be involved. So, if the steps above don't work for you. Try to play a bit with the UI (context switching, stepping) before resuming both.

Honza

Thanks i can reproduce with this STR
This looks like a different issue causing this with the same symptom ,
I have a fix for it so I'll open a separate bug for it.

Comment 6

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1717807 - [devtools] Resume the front-end on will navigate

Depends on D119624

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I just tried the patch and it fixes the issue for me.

Note that sometimes, when I navigate BACK to http://janodvarko.cz/tests/fission/case1/index.html the BP in janodvarko.cz/index.js file, line 3 is not hit. Sometimes it is. But, this isn't part of this bug report. Do we want to file another bug for it?

Honza

Comment 8

[Hubert Boma Manilla (:bomsy)]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #7)

I just tried the patch and it fixes the issue for me.

Note that sometimes, when I navigate BACK to http://janodvarko.cz/tests/fission/case1/index.html the BP in janodvarko.cz/index.js file, line 3 is not hit. Sometimes it is. But, this isn't part of this bug report. Do we want to file another bug for it?

Honza

Thanks for testing.
Yes lets file and investigate that as a separate bug as it relates to the BP not actually getting hit while this relates to debugger tab highlighting.

Comment 9

[Chris Peterson [:cpeterson]]

This bug is a soft blocker for Fission MVP. We'd like to fix it before our Release channel rollout, but we won't delay the rollout waiting for it.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1185c79bedc4
[devtools] Resume the front-end on will navigate r=ochameau

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1185c79bedc4