Add background hang reporting for "Renderer" thread
Categories
(Core :: Graphics: WebRender, enhancement, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: bradwerth)
Details
Attachments
(3 files)
|
Reporter | |
Comment 1•3 years ago
|
||
Well it looks like we could technically plumb this together on top of the Chromium thread stuff it seems like we'd have to reach into the guts to figure out when the thread is going to wait. It's probably better to just switch to using an nsThread like the Compositor thread.
|
Assignee | |
Comment 2•3 years ago
|
||
I'll take this on.
|
|
Assignee | |
Comment 3•3 years ago
|
||
Instead of warning against callers directly accessing the thread message loop,
actuually prevent them from doing so. This is also a preliminary step to
changing the type of the internally-created thread, which will no longer
directly expose its message loop.
|
|
Reporter | |
Comment 4•3 years ago
|
||
FWIW, I had this WIP before going on leave. It looks like you're doing it more cleanly.
|
|
Assignee | |
Comment 5•3 years ago
|
||
The background hang monitor uses the same timing thresholds as the one used by
the compositor thread, for similar reasons.
Depends on D119562
|
|
Assignee | |
Comment 6•3 years ago
|
||
|
|
Assignee | |
Comment 7•3 years ago
|
||
Had to add "Renderer" to ThreadAllows.txt. New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfc095053ee419296befdceca2b72ea170f49bbe
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8614cd64ce97 Part 1: Abstract RenderThread task pushing, and make it private. r=gfx-reviewers,jrmuizel https://hg.mozilla.org/integration/autoland/rev/8da7074793a3 Part 2: Make RenderThread backed by nsIThread, with a hang monitor. r=gfx-reviewers,jrmuizel
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8614cd64ce97
https://hg.mozilla.org/mozilla-central/rev/8da7074793a3
Description
•