1717908 - Pausing feed account root folder no longer sets a property for reduced opacity UI feedback

Status: ASSIGNED

(Thunderbird :: Folder and Message Lists, defect)

Description

[alta88]

Both the account folder and all child folders should have reduced opacity. However, pausing individual folders does work correctly. Probably a regression from recent folderpane caching work.

Comment 1

[Alessandro Castellani [:aleca]]

Thanks for the report.
I'm not aware of this feature, sorry, could you give me some pointers for me to test it in 78 and daily so I can see the regression?
Cheers.

Comment 2

[alta88]

Set up a feed account, add a feed or two. Right click menu on the account item in folderpane, check pause all updates. Updates are turned off for all feeds in the account, and this is indicated by reduced opacity on the account and all subfolders with feeds.

Comment 3

[Magnus Melin [:mkmelin]]

Probably some rule taking precedence over https://searchfox.org/comm-central/rev/1886f2f7853578563f14fa9ed4191508fa3b6a57/mail/themes/shared/mail/folderPane.css#169 for the account nodes.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1717908-feed-paused-style.patch

This fixes the issue that the server never gets the disabled appearance.

But there is still the issue that the state isn't updated on change through the menu. I need to select the items again to let them know the actual status -> this is not a CSS issue.

Comment 5

[alta88]

Something probably about not setting/getting the folder cache property correctly or not invalidating the cell.

Comment 6

[Alessandro Castellani [:aleca]]

Sorry for the delay in reviewing this, I just got back from vacation :D.
I'll take a look at the caching implementation and see if I can solve the issue of the row not properly invalidating when required.

Comment 7

[Alessandro Castellani [:aleca]]

Comment on attachment 9232820 [details] [diff] [review]
1717908-feed-paused-style.patch

Review of attachment 9232820 [details] [diff] [review]:
-----------------------------------------------------------------

Good fix, but as you said not totally complete.
Let's keep this here until I find the culprit and then we can land everything together.