1717932 - [wpt-sync] Sync PR 29244 - [LayoutNG] Multicol with OOF contained by inline ancestor

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 29244 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29244
Details from upstream follow.

b'Alison Maher <[e-mail]>' wrote:

[LayoutNG] Multicol with OOF contained by inline ancestor

An OOF with an inline containing block that is a direct child of a
multicol crashed because the containing block of the inline element was
detected to be the LayoutFlowThread. The reason being that
LayoutObject::FindNonAnonymousContainingBlock() checks
IsAnonymousBlock() when finding the containing block, which can be
a LayoutFlowThread. However, IsAnonymousBlock() also skips over the
anonymous wrapper of the inline container. We want to use this as the
containing block instead so that we don't end up using the
multicol as the containing block.

To accomplish this, add a new bitfield for the inline NG wrapper that
is a direct child of a flow thread in LayoutObject, and allow this to be
the containing block in LayoutObject::FindNonAnonymousContainingBlock().

Bug: 1079031
Change-Id: I90dc78fc541abf2a93a62da808542787a3ad2e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2938502
Commit-Queue: Alison Maher \<[e-mail]>
Reviewed-by: Morten Stenshorne \<[e-mail]>
Reviewed-by: Aleks Totic \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#895300}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e4a5a229eb0ab348f3e7695d59374fd88e03b1b

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/out-of-flow-in-multicolumn-056.html: FAIL

New Tests That Don't Pass

/css/css-break/out-of-flow-in-multicolumn-056.html: FAIL (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01a55d67733e
[wpt PR 29244] - [LayoutNG] Multicol with OOF contained by inline ancestor, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9ddac515f459
[wpt PR 29244] - Update wpt metadata, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/01a55d67733e
https://hg.mozilla.org/mozilla-central/rev/9ddac515f459