1717979 - DevTools watch methods should throw when provided with unknown resource/target types

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

The following destroy code was failing to unwatch REFLOW resources properly because it used ResourceCommand.REFLOW instead of ResourceCommand.TYPES.REFLOW.

https://searchfox.org/mozilla-central/rev/f213971fbd82ada22c2c4e2072f729c3799ec563/devtools/client/inspector/inspector.js#1561-1566

  untrackReflowsInSelection() {
    this.commands.resourceCommand.unwatchResources(
      [this.commands.resourceCommand.REFLOW],
      {
        onAvailable: this.onReflowInSelection,
      }
    );
  },

This kind of mistake could be prevented at framework level by validating the types passed to watch/unwatch methods.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1717979 - [devtools] watch/unwatch APIs should throw when provided with invalid types

Depends on D118669

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d248b995cc49
[devtools] watch/unwatch APIs should throw when provided with invalid types r=ochameau

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d248b995cc49