1718064 - ProcessPriorityManager.cpp:101:36: error: baseprofiler has not been declared

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

I see these on Solaris:

 7:49.82 /builds/psumbera/mozilla-central-build/dom/ipc/ProcessPriorityManager.cpp:101:36: error: baseprofiler has not been declared
 7:49.82   101 |   static void StreamJSONMarkerData(baseprofiler::SpliceableJSONWriter& aWriter,
 7:49.82       |                                    ^~~~~~~~~~~~
 7:49.87 /builds/psumbera/mozilla-central-build/dom/ipc/ProcessPriorityManager.cpp:103:42: error: ProfilerString8View does not name a type
 7:49.87   103 |                                    const ProfilerString8View& aPreviousPriority,
 7:49.87       |                                          ^~~~~~~~~~~~~~~~~~~
 7:49.92 /builds/psumbera/mozilla-central-build/dom/ipc/ProcessPriorityManager.cpp:104:42: error: ProfilerString8View does not name a type
 7:49.92   104 |                                    const ProfilerString8View& aNewPriority) {
 7:49.92       |                                          ^~~~~~~~~~~~~~~~~~~

The first bad revision is:
changeset: 584235:9b2ffc8e8505
tag: tip
user: Gerald Squelart <[e-mail]>
date: Thu Jun 24 00:25:56 2021 -0700
description:
Bug 1667818 - Record priority change markers - r=canaltinova

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Gecko Profiler' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Florian Quèze [:florian]]

Thanks for filing! There was an ifdef that was forgotten in bug 1667818. But bug 1717991 (currently in review) is fixing this entire class of problems and removing all these ifdefs, so depending on how quickly the review goes, it might be a better fix than adding one more ifdef.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Sorry for the trouble (again).
I'll be reviewing bug 1717991 today, so hopefully it will land soon and fix this bug here as well, and even prevent future build issues like it -- but not all of them yet, for that we intend to completely get rid of MOZ_GECKO_PROFILER eventually, see bug 1635350.

Comment 4

[Dan Horák]

For the record, ppc64le and s390x are also affected.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1667818

Comment 6

[Florian Quèze [:florian]]

Fixed by bug 1717991.