171807 - can't create or manage folders

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Asa Dotzler [:asa]]

This is a very recent regression. 

I cannot create or manage folders in today's builds. I think this worked
yesterday or the day before.

Comment 1

[Asa Dotzler [:asa]]

*** Bug 171689 has been marked as a duplicate of this bug. ***

Comment 2

[Asa Dotzler [:asa]]

*** Bug 171803 has been marked as a duplicate of this bug. ***

Comment 3

[Asa Dotzler [:asa]]

When clicking New Folder... in the Add Bookmark dialog this shows in the JS console:

Error: bookmarksView.createNewFolder is not a function
Source File: chrome://browser/content/bookmarks/addBookmark.js      Line 293


Pierre, we really should fix this before we do 0.2 (scheduled for tomorrow). 

Comment 4

[André Dahlqvist]

I guess "manage" maybe includes this, but I'm just going to point it out to be
sure: when you right-click on a folder in Manage Bookmarks and choose Properties
nothing happens. This is with todays CVS.

Comment 5

[Pierre Chanial]

André is right. everything should be fixed. If there are remaining issues, give
me a testcase.
Note that cancel does not remove the new folder. I'll fix while coding a new
'add bookmark' dialog

Comment 6

[bill davenport]

Reproducible: Always

Steps to Reproduce:
1.Go to Bookmarks -> Add to Bookmarks...
2.Select New Foler
4.Nothing Happens

After looking at "Add to Bookmarks..." it seems that it should be a quick way to
save a bookmark to a folder or to create a new folder to save the bookmark in. 
However, I think it would be better to simplify this by changing "new folder"
button to say "manage folder".  The "manage folder" button would link to the
Bookmark Manager.  That way it if someone wants to create a new folder they can
have all the features of the Bookmark Manager.

Also, if "manage folder" button is pushed then the bookmark should be forwarded
to the Bookmark Manager. (a little to obvious I know, but had to be said)

I would also suggest to make the "create in" window in the "Add to Bookmarks..."

Comment 7

[bill davenport]

Sorry, didn't give important info:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20020930 Phoenix/0.2

Comment 8

[Simon Paquet [:sipaq]]

verified.