Closed Bug 1718120 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29483 - Revert "Auto-expand details elements for find-in-page"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29483 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29483
Details from upstream follow.

b'Aleks Totic <atotic@chromium.org>' wrote:

Revert "Auto-expand details elements for find-in-page"

This reverts commit 02660fd7a1202f9ff9a615cb7e83af6075d7a93d.

Reason for revert: crbug.com/1221221

Clusterfuzz found a use-after-poison caused by this CL. The root cause is observable in the debug build.

Original change's description:

Auto-expand details elements for find-in-page

This patch makes \<details> expand automatically in response to
find-in-page right before find-in-page tries to scroll to content inside
a closed \<details> element.

This is gated behind the experimental web platform features flag.

I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/ovNo2kFAgnE

Bug: 1058732, 1185950
Change-Id: Ie957d2835ce90e4c777341e0518c91442990fded
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702377
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Reviewed-by: Aaron Leventhal \<aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#893228}

Bug: 1058732, 1185950
Change-Id: Iea6996494edbe4d803e956546f16caed8179b7cc

Reviewed-on: https://chromium-review.googlesource.com/2985840
WPT-Export-Revision: cd8d8a3b9b17fa88f75888b1a2a9edc532bdcda4

PR 29483 applied with additional changes from upstream: 572f1a6056355546771c3a75e9e24c88c32017dd
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f16aac68eeab
[wpt PR 29483] - Revert "Auto-expand details elements for find-in-page", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.