Closed Bug 1718128 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29485 - Fix fragment tree consistency in ContributionSizeForGridItem

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29485 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29485
Details from upstream follow.

b'Koji Ishii <kojii@chromium.org>' wrote:

Fix fragment tree consistency in ContributionSizeForGridItem

|BlockContributionSize| in |NGGridLayoutAlgorithm::
ContributionSizeForGridItem| runs layout but discard the
result. In most cases, |NGGridLayoutAlgorithm| runs another
layout, which picks up from the cache, and add it to the
fragment tree.

However, there are some cases where it computes the size after
layout. In this case, the algorithm may or may not run another
layout. Not running can make the fragment tree inconsistent
that this patch disables caching in that case.

Bug: 1221766
Change-Id: I29d27be7d295559cbd9a1ec9d63c40eefd0b422c

Reviewed-on: https://chromium-review.googlesource.com/2985700
WPT-Export-Revision: e893969ea86546dc4d734b1812daab2583948e23

Component: web-platform-tests → Layout: Grid
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.