1718237 - Mozilla Notifications emails could have less linkified content at start

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect)

Description

[Mark Banner (:standard8)]

Attachment: Comparison screenshot

I find the combination of two lines of underlined text at the start of the notification emails to be quite distracting.

I don't think they generally need to be noticed, as the first line overlaps with the subject message anyway.

I think we could only join link the numbers, and then it'd look a bit better. I'm attaching a comparison.

Comment 1

[Mark Banner (:standard8)]

Attachment: GitHub Pull Request

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Interesting! I'm a little ambivalent - one one hand, I think that the top "revision" link is frequently used, and therefore increasing the size of the link makes it more usable, since it's easier to click (at which point, the bug link should be long as well for consistency).

However, I'm open to change here, especially if you've felt strongly enough about this to create a patch :)
I'll defer this to Zeid, the future phab-emails maintainer: if he thinks it's nicer with smaller links, let's land this!

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

I'll be digging into reviewing this soon (ideally this week or next week).
Thanks for the patch :)

Comment 4

[Mark Banner (:standard8)]

This landed in https://github.com/mozilla-conduit/phabricator-emails/commit/1b2e747952b8858b8a5a5a974cbfeae2fd077247