1718295 - Use an indentation of two spaces on all CSS files

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Richard Marti (:Paenglab)]

Actually most of the calendar CSS files have an indentation of 4 spaces. The default on the tree is 2 spaces.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1718295-calendar-indentation.patch

This is only a indentation change.

Comment 2

[Richard Marti (:Paenglab)]

And it needs bug 1717637 applied first which has checkin-needed set.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9228997 [details] [diff] [review]
1718295-calendar-indentation.patch

Review of attachment 9228997 [details] [diff] [review]:
-----------------------------------------------------------------

I'm okay with this as I think having consistent indentation across the code base is important.
I'm redirecting the review to Magnus just to be sure this is okay and there isn't any particular reason to keep 4 spaces indentation in CSS.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9228997 [details] [diff] [review]
1718295-calendar-indentation.patch

Review of attachment 9228997 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
I think there is (limited) support for ignoring such changesets by adding a comment like "# ignore-this-changeset" on its own line

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1718295-calendar-indentation.patch

Added the # ignore-this-changeset to the commit message.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1718295-calendar-indentation.patch

Rebased after the renames in bug 1710548.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5685983ba9b8
[Calendar] Use an indentation of two spaces on all CSS files. r=aleca