Closed
Bug 1718469
Opened 3 years ago
Closed 3 years ago
Wrong indent for menuitems with checkmark in composition's File > Save As submenu
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird_esr78 unaffected)
VERIFIED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
People
(Reporter: thomas8, Assigned: Paenglab)
Details
Attachments
(2 files)
|
14.52 KB,
image/png
|
Details | |
|
1.45 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
grafik.png
Seen on Beta and Daily 91.0a1 (2021-06-27) (64-bit), Win10
Compose, File > Save As
Actual
- menuitem with checkmark wrongly indented (see screenshot)
Expected
- correct indent
|
Assignee | |
Comment 1•3 years ago
|
||
I added > to let the rule only apply on direct parents. Before it happened that it used the wrong parent.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9229306 -
Flags: review?(alessandro)
|
||
Comment 2•3 years ago
|
||
Comment on attachment 9229306 [details] [diff] [review] 1718469-needsgutter.patch Review of attachment 9229306 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Attachment #9229306 -
Flags: review?(alessandro) → review+
|
|
Assignee | |
Updated•3 years ago
|
Keywords: checkin-needed-tb
Target Milestone: --- → 91 Branch
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/b0395c4387f9
Make the [needsgutter] rules check explicitly the parent menupopup. r=aleca
You need to log in
before you can comment on or make changes to this bug.
Description
•