Closed Bug 1718469 Opened 1 year ago Closed 1 year ago

Wrong indent for menuitems with checkmark in composition's File > Save As submenu

Categories

(Thunderbird :: Theme, defect)

Unspecified
Windows 10
defect

Tracking

(thunderbird_esr78 unaffected)

VERIFIED FIXED
91 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: thomas8, Assigned: Paenglab)

Details

Attachments

(2 files)

Attached image grafik.png

Seen on Beta and Daily 91.0a1 (2021-06-27) (64-bit), Win10

Compose, File > Save As

Actual

  • menuitem with checkmark wrongly indented (see screenshot)

Expected

  • correct indent

I added > to let the rule only apply on direct parents. Before it happened that it used the wrong parent.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9229306 - Flags: review?(alessandro)
Comment on attachment 9229306 [details] [diff] [review]
1718469-needsgutter.patch

Review of attachment 9229306 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #9229306 - Flags: review?(alessandro) → review+
Target Milestone: --- → 91 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/b0395c4387f9
Make the [needsgutter] rules check explicitly the parent menupopup. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Thanks!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.