Closed Bug 1718524 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29518 - Append nested fragmentainers for OOFs if needed.

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29518 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29518
Details from upstream follow.

b'Morten Stenshorne <mstensho@chromium.org>' wrote:

Append nested fragmentainers for OOFs if needed.

In a nested fragmentation context (e.g. multicol in multicol), if an OOF
couldn't fit in the fragmentainers than we already had, we'd just put
multiple fragments for the same OOF into the last fragmentainer, with an
additional inline-offset for each fragment.

With an upcoming pre-paint change, this approach is problematic, since
we want to use the fragmentainer index as a unique identifier for each
FragmentData entry.

This CL fixes that. We'll now create as many inner fragmentainers that
we need, and never put more than one fragment for the same node into the
same fragmentainer. This requires us to regenerate inner multicol
container fragments, and overwrite references to the old fragments.

One consequence of fixing this is that we now also get column rules
right in such cases, since column rule painting is based on having
the actual fragmentainers there.

Bug: 1043787, 1079031
Change-Id: Ie94440a199636f5e29f3443d0ae37a8d079c3759
Reviewed-on: https://chromium-review.googlesource.com/2988124
WPT-Export-Revision: 2cd214baaee2cf686e7c563796ce085101f642d3

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1b4a6f6607a
[wpt PR 29518] - Append nested fragmentainers for OOFs if needed., a=testonly

https://hg.mozilla.org/mozilla-central/rev/f1b4a6f6607a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.