Closed
Bug 1718529
Opened 3 years ago
Closed 3 years ago
Use JS_ExecuteScript instead of JS::CloneAndExecuteScript in EvalStencil and mozJSComponentLoader::ObjectForLocation
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
94 Branch
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(3 files)
After bug 1688788, mozJSComponentLoader::ObjectForLocation
and EvalScript
instantiates the script just before calling JS::CloneAndExecuteScript
, that means it doesn't have to clone.
we can use JS_ExecuteScript
instead, so that remaining non-testing JS::CloneAndExecuteScript
callsites are all removed.
Assignee | ||
Comment 1•3 years ago
|
||
Depends on D121254
Assignee | ||
Comment 2•3 years ago
|
||
Depends on D121255
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D121256
Updated•3 years ago
|
Attachment #9233807 -
Attachment description: WIP: Bug 1718529 - Part 1: Use JS_ExecuteScript instead of JS::CloneAndExecuteScript when same-realm is guaranteed. r?tcampbell! → Bug 1718529 - Part 1: Use JS_ExecuteScript instead of JS::CloneAndExecuteScript when same-realm is guaranteed. r?tcampbell!
Updated•3 years ago
|
Attachment #9233808 -
Attachment description: WIP: Bug 1718529 - Part 2: Remove cloneAndExecuteScript testing function. r?tcampbell! → Bug 1718529 - Part 2: Remove cloneAndExecuteScript testing function. r?tcampbell!
Updated•3 years ago
|
Attachment #9233809 -
Attachment description: WIP: Bug 1718529 - Part 3: Remove JS::CloneAndExecuteScript. r?tcampbell! → Bug 1718529 - Part 3: Remove JS::CloneAndExecuteScript. r?tcampbell!
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/cf2422a4cf0b Part 1: Use JS_ExecuteScript instead of JS::CloneAndExecuteScript when same-realm is guaranteed. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/51a0210ff990 Part 2: Remove cloneAndExecuteScript testing function. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/506b2659c7f9 Part 3: Remove JS::CloneAndExecuteScript. r=tcampbell
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cf2422a4cf0b
https://hg.mozilla.org/mozilla-central/rev/51a0210ff990
https://hg.mozilla.org/mozilla-central/rev/506b2659c7f9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•