Closed Bug 1718532 Opened 3 years ago Closed 3 years ago

Intermittent browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | A tab with tabId 862 has been leaked in the tabTracker ("undefined") -

Categories

(WebExtensions :: Untriaged, defect, P5)

defect

Tracking

(firefox94 fixed)

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: smaug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=344023644&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PawQ7PCnTLyB-Um7xBj2Ew/runs/0/artifacts/public/logs/live_backing.log


INFO - TEST-START | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js
[task 2021-06-28T12:58:40.571Z] 12:58:40     INFO - TEST-INFO | started process screentopng
[task 2021-06-28T12:58:40.926Z] 12:58:40     INFO - TEST-INFO | screentopng: exit 0
[task 2021-06-28T12:58:40.928Z] 12:58:40     INFO - Buffered messages logged at 12:58:37
[task 2021-06-28T12:58:40.929Z] 12:58:40     INFO - Entering test bound testWindowCreate
[task 2021-06-28T12:58:40.930Z] 12:58:40     INFO - Extension loaded
[task 2021-06-28T12:58:40.932Z] 12:58:40     INFO - Console message: Warning: attempting to write 43080 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
[task 2021-06-28T12:58:40.933Z] 12:58:40     INFO - Create additional tab in window 1
[task 2021-06-28T12:58:40.934Z] 12:58:40     INFO - Buffered messages logged at 12:58:38
[task 2021-06-28T12:58:40.934Z] 12:58:40     INFO - Create a new window, adopting the new tab
[task 2021-06-28T12:58:40.936Z] 12:58:40     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | Tab is not private - Expected: false, Actual: false - 
<...>
 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | test result correct - 
[task 2021-06-28T12:58:40.974Z] 12:58:40     INFO - Buffered messages finished
[task 2021-06-28T12:58:40.975Z] 12:58:40     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | A tab with tabId 862 has been leaked in the tabTracker ("undefined") - 
[task 2021-06-28T12:58:40.975Z] 12:58:40     INFO - Stack trace:
[task 2021-06-28T12:58:40.975Z] 12:58:40     INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-06-28T12:58:40.975Z] 12:58:40     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js:assertNoLeaksInTabTracker:14
[task 2021-06-28T12:58:40.975Z] 12:58:40     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js:testWindowCreate:213
[task 2021-06-28T12:58:40.976Z] 12:58:40     INFO - Leaving test bound testWindowCreate
[task 2021-06-28T12:58:40.976Z] 12:58:40     INFO - Entering test bound testWebNavigationOnWindowCreateTabId
[task 2021-06-28T12:58:41.213Z] 12:58:41     INFO - Extension loaded
[task 2021-06-28T12:58:41.221Z] 12:58:41     INFO - Console message: Warning: attempting to write 43160 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
[task 2021-06-28T12:58:41.255Z] 12:58:41     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | Got the expected number of test tabs - Expected: 2, Actual: 2 - 
[task 2021-06-28T12:58:42.136Z] 12:58:42     INFO - Waiting tabs move to new window to be attached
[task 2021-06-28T12:58:42.138Z] 12:58:42     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | No webNavigation.onCompleted event should have been received - Expected: [], Actual: [] - 
[task 2021-06-28T12:58:42.244Z] 12:58:42     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | webNavigation-on-window-create-tabId - 
[task 2021-06-28T12:58:42.245Z] 12:58:42     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | test result correct - 
[task 2021-06-28T12:58:42.260Z] 12:58:42     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-06-28T12:58:42.260Z] 12:58:42     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | A tab with tabId 862 has been leaked in the tabTracker ("undefined") - 
[task 2021-06-28T12:58:42.261Z] 12:58:42     INFO - Stack trace:
[task 2021-06-28T12:58:42.261Z] 12:58:42     INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-06-28T12:58:42.262Z] 12:58:42     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js:assertNoLeaksInTabTracker:14
[task 2021-06-28T12:58:42.262Z] 12:58:42     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js:testWebNavigationOnWindowCreateTabId:307
[task 2021-06-28T12:58:42.263Z] 12:58:42     INFO - Leaving test bound testWebNavigationOnWindowCreateTabId
[task 2021-06-28T12:58:42.263Z] 12:58:42     INFO - Entering test bound testGetLastFocusedDoesNotLeakDuringTabAdoption
[task 2021-06-28T12:58:42.573Z] 12:58:42     INFO - Extension loaded
[task 2021-06-28T12:58:42.579Z] 12:58:42     INFO - Console message: Warning: attempting to write 43240 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
[task 2021-06-28T12:58:43.025Z] 12:58:43     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | Got the expecte
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Summary: Intermittent [Tier 2] browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | A tab with tabId 862 has been leaked in the tabTracker ("undefined") - → Intermittent browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | A tab with tabId 862 has been leaked in the tabTracker ("undefined") -

The leak I can reproduce locally somewhat often is coming from
https://searchfox.org/mozilla-central/rev/08c493902519265d570250c8e7ce575c8cd6f5b5/browser/components/extensions/test/browser/browser_ext_windows_create_cookieStoreId.js#308,319-321
When adopting a tab to a new window, there is internally a frameloader swap.
The initial frameloader is loading about:blank and already after the old window has started to close
https://searchfox.org/mozilla-central/rev/08c493902519265d570250c8e7ce575c8cd6f5b5/browser/actors/AboutReaderParent.jsm#156 triggers a call to
extension code where getId is called. The failure becomes almost perma-fail with bug 1727829.

Will push this with bug 1727829 to tryserver.

Depends on D124091

Assignee: nobody → bugs
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ee2b07892cb don't try to create tabId if the relevant window is already closing, r=rpl
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: