cal.itip no longer uses calendar's transport
Categories
(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)
Tracking
(thunderbird_esr78 unaffected, thunderbird90 affected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
| thunderbird90 | --- | affected |
People
(Reporter: neil, Assigned: neil)
References
(Regression)
Details
Attachments
(1 file, 1 obsolete file)
|
2.48 KB,
patch
|
darktrojan
:
review+
lasana
:
review+
|
Details | Diff | Splinter Review |
The itip transport for an item is supposed to be retrieved by calling item.calendar.getProperty("itip.transport"). Bug 1710172 substituted that with cal.provider.getImipTransport(item.calendar), however that's actually a utility function for calendar providers to call as part of their handling of the getProperty call.
(Edit: Ugh, I always get imip and itip confused. Sigh...)
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
... the test wasn't even providing the transport correctly...
|
||
Updated•3 years ago
|
|
||
Comment 3•3 years ago
|
||
Hello.
What's the intended effect here, seeing as getProperty("itip.transport") calls calprovider.getImipTransport()? Am I missing something?
It seemed to me that configuring the transport of a calendar is a feature not quite implemented.
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Comment 5•3 years ago
•
|
||
Lasana wrote in comment 3:
Am I missing something?
Other calendar providers, which might need a different implementation. You've basically hardcoded one implementation, making other implementations impossible.
|
|
||
Comment 6•3 years ago
|
||
(In reply to Ben Bucksch (:BenB) from comment #5)
Lasana wrote in comment 3:
Am I missing something?
Other calendar providers, which might need a different implementation. You've basically hardcoded one implementation, making other implementations impossible.
Thanks for the reply. Other providers from where, extensions?
|
|
||
Comment 7•3 years ago
•
|
||
Yes, there are many calendar providers.
|
|
||
Updated•3 years ago
|
|
|
||
Comment 8•3 years ago
|
||
Comment on attachment 9229197 [details] [diff] [review]
Fixed bug and test
This should be OK. I'm not too familiar with the extension infrastructure but if they can register additional providers it makes sense.
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/097aa8f960e2
Fetch the itip.transport calendar property again. r=lasana,darktrojan
|
|
||
Updated•3 years ago
|
Description
•