1718623 - Investigate cloning with different JSScript::ImmutableFlags::HasNonSyntacticScope value.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

CloneGlobalScript supports cloning into different syntactic/non-syntactic global scope.
if it's still necessary, we should support instantiating with different syntactic/non-syntactic global scope.
if it's no more used, we can remove that, and also look into JSOp::GImplicitThis [1]

[1] https://searchfox.org/mozilla-central/rev/ed5c7b4262d4e30656886a45321cbbf4200de349/js/src/vm/Opcodes.h#1782-1787

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718623 - Drop support for cloning between syntactic/non-syntactic scopes. r?tcampbell!

Comment 2

[Tooru Fujisawa [:arai]]

this patch stack is based on ScriptPreloader patches (bug 1688790 and bug 1688788)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7cb7313d1c7
Drop support for cloning between syntactic/non-syntactic scopes. r=tcampbell

Comment 4

[Atila Butkovits]

Backed out for causing leaks.

Backout link: https://hg.mozilla.org/integration/autoland/rev/67b1f53e79bbd755fb285606dcd246b5ae131295

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=cm4Ib7QxR1SVp5Lp0SBCVQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1cd8bdf1fc92414f6e3a0784ac37e8fe31a64771

Failure log: https://treeherder.mozilla.org/logviewer?job_id=351989321&repo=autoland&lineNumber=3022

Comment 5

[Andreea Pavel [:apavel]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/67b1f53e79bbd755fb285606dcd246b5ae131295

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59ba9c430403
Drop support for cloning between syntactic/non-syntactic scopes. r=tcampbell

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/59ba9c430403