Closed
Bug 1718635
Opened 3 years ago
Closed 3 years ago
Relax JSOp::GImplicitThis requirement
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
in bug 1718623, I verified that script cloning doesn't happen between syntactic/non-syntactic scope.
There's a requirement about JSOp::GImplicitThis because of the cloning between syntactic/non-syntactic scope, but given above (and we're going to remove script cloning in bug 1662152),
we can relax the requirement and emit JSOp::Undefined for global unqualified function calls.
|
Assignee | |
Comment 1•3 years ago
|
||
(In reply to Tooru Fujisawa [:arai] from comment #0)
in bug 1718623, I verified that script cloning doesn't happen between syntactic/non-syntactic scope.
This is true also after switching from script cloning to stencil instantiation,
that script compiled against syntactic scope isn't instantiated for non-syntactic scope.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D121277
|
||
Updated•3 years ago
|
Attachment #9233830 -
Attachment description: WIP: Bug 1718635 - Emit JSOp::Undefined instead of JSOp::GImplicitThis if there's no non-syntactic scope when calling unqualified function. r?tcampbell! → Bug 1718635 - Emit JSOp::Undefined instead of JSOp::GImplicitThis if there's no non-syntactic scope when calling unqualified function. r?tcampbell!
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/3658a80b874d Emit JSOp::Undefined instead of JSOp::GImplicitThis if there's no non-syntactic scope when calling unqualified function. r=tcampbell
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•