Closed Bug 1718650 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29530 - <input type=time> with datalist triggers !IsValid() DCHECK

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29530 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29530
Details from upstream follow.

b'Aaron Leventhal <aleventhal@google.com>' wrote:

<input type=time> with datalist triggers !IsValid() DCHECK

  1. Only perform validity checks on truly plain text fields.
  2. Remove BrowserAccessibility::IsValid() from non-DCHECK builds.

Bug: 1221781
Cq-Include-Trybots: luci.chromium.try:linux-blink-web-tests-force-accessibility-rel
Change-Id: I5719fa84950f038f19ebe9c616db5946c52e0242

Reviewed-on: https://chromium-review.googlesource.com/2983437
WPT-Export-Revision: efe6f2aa33998dbd99901b4f3757485a41d5c665

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af735a8ea54d [wpt PR 29530] - <input type=time> with datalist triggers !IsValid() DCHECK, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.