1718653 - [Wayland] Update notification partly off-screen

Status: RESOLVED DUPLICATE of bug 1718867

(Core :: Widget: Gtk, defect, P3)

Description

[Kevin Locke]

Attachment: Screenshot with update notification cut off along right edge

With Thunderbird Daily 91.0a1 (2021-06-28) (64-bit) on Sway 1.6 (Wayland) with MOZ_ENABLE_WAYLAND=1 set in the environment, the update notification pop-up is mostly cut off by the right edge of the screen (or window). See attached screenshot.

I'd be happy to test on XWayland or XWindows, or to bisect if that's likely to be helpful, but I'm not sure how to cause the update notification pop-up to appear. Suggestions appreciated.

Comment 1

[Kevin Locke]

Attachment: Screenshot with update notification on XWayland (i.e. without MOZ_ENABLE_WAYLAND)

The update notification pop-up appears to be correctly positioned on Sway 1.6 (Wayland) when MOZ_ENABLE_WAYLAND is not set in the environment. Screenshot attached.

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Kevin Locke from comment #0)

I'm not sure how to cause the update notification pop-up to appear. Suggestions appreciated.

I found that you can spoof popups using the console

PopupNotifications.show(getBrowser(), "testing-id", "this is a message", "addons-notification-icon", null, null, null);

Note, the popup won't appear until you refocus the main window (away from the console).

Regarding the bug, I didn't reproduce this on my system (fedora 33, gnome 3.38.5) with MOZ_ENABLE_WAYLAND=1, but I don't use Sway.

Comment 3

[Kevin Locke]

Attachment: Screenshot of test PopupNotification on Sway with MOZ_ENABLE_WAYLAND=1

(In reply to Henry Wilkes [:henry] from comment #2)

I found that you can spoof popups using the console

PopupNotifications.show(getBrowser(), "testing-id", "this is a message", "addons-notification-icon", null, null, null);

Thanks :henry! Interestingly, although that did create a similar popup, it doesn't exhibit the issue on my system under Sway either. Screenshot attached.

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Kevin Locke from comment #3)

Thanks :henry! Interestingly, although that did create a similar popup, it doesn't exhibit the issue on my system under Sway either. Screenshot attached.

Ah, interesting.

I tried with this

PopupNotifications.show(getBrowser(), "testing-id", "this is a message", "addons-notification-icon", null, null, { persistent: true });

And I was able to reproduce the bug! (again, using fedora 33 and gnome (no Swift)).

So it seems that the persistent option is playing some role. I wonder if it could be the noautohide attribute on the panel that is the origin (https://searchfox.org/comm-central/rev/5205096239780c1697671f11161be1d8f328dd46/mail/modules/GlobalPopupNotifications.jsm#966).

Note the upstream PopupNotifications from mozilla-central has the same lines (https://searchfox.org/comm-central/rev/5205096239780c1697671f11161be1d8f328dd46/mozilla/toolkit/modules/PopupNotifications.jsm#1271), so this problem may also be present in Firefox.

Comment 5

[Henry Wilkes (they/them) [:henry-x]]

Opened a bug in Core: Widget: Gtk (Bug 1718867). It isn't much of a problem in the firefox case, so I'm not sure if it'll get much attention, but I've set it as blocking for now.

Comment 6

[Kevin Locke]

Thanks :henry! Good find on the persistent option and the reproduction in Firefox. Thanks for opening Bug 1718867. Understandable if it (or this issue) is low priority. It's not a significant pain point for me at the moment. Thanks again for working on it!

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Is there away how to reproduce it in Firefox? I can be fixed and I have an idea how to fix that but would be great to fix that on FF side first.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Should be partially fixed by Bug 1718867.