Closed Bug 1718686 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29534 - [webcodecs] Replace ConstraintError.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29534 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29534
Details from upstream follow.

b'Dan Sanders <sandersd@chromium.org>' wrote:

[webcodecs] Replace ConstraintError.

ConstraintError was used early in development but doesn't accurately
describe the nature of errors in WebCodecs. This CL replaces all uses
with more appropriate errors.

In most cases, the correct error is a TypeError, indicating that
arguments were not valid according to the specification. In cases where
an implementation detail resulted in a ConstraintError, OperationError
is used.

Change-Id: If124557e2fe9fb8d9f150ad107b627def75f27a3
Reviewed-on: https://chromium-review.googlesource.com/2993573
WPT-Export-Revision: 3d91329df2d36a4b295d2fb9da7a5c948a5a1f67

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 13 subtests

Status Summary

Firefox

OK : 4
FAIL: 58

Chrome

OK : 4
PASS: 38
FAIL: 20

Safari

OK : 4
FAIL: 58

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/video-frame.any.worker.html
Test we can construct a VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame with a negative timestamp.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct an odd-sized VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can read planar data from a VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test we cannot read planar data from a closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing VideoFrames from closed ImageBitmap throws.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid planar constructed VideoFrames: FAIL (Chrome: FAIL, Safari: FAIL)
Test planar constructed I420 VideoFrame: FAIL (Chrome: FAIL, Safari: FAIL)
Test planar constructed I420+Alpha VideoFrame: FAIL (Chrome: FAIL, Safari: FAIL)
Test planar constructed NV12 VideoFrame: FAIL (Chrome: FAIL, Safari: FAIL)
Test planar constructed RGB VideoFrames: FAIL (Chrome: FAIL, Safari: FAIL)
Test VideoFrame constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame from an offscreen canvas.: FAIL (Chrome: PASS, Safari: FAIL)
Test I420A VideoFrame and alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test RGBA, BGRA VideoFrames with alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test a VideoFrame constructed from canvas can drop the alpha channel.: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/video-frame.any.html
Test we can construct a VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame with a negative timestamp.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct an odd-sized VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test we can read planar data from a VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test we cannot read planar data from a closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Test constructing VideoFrames from closed ImageBitmap throws.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid planar constructed VideoFrames: FAIL (Chrome: FAIL, Safari: FAIL)
Test planar constructed I420 VideoFrame: FAIL (Chrome: FAIL, Safari: FAIL)
Test planar constructed I420+Alpha VideoFrame: FAIL (Chrome: FAIL, Safari: FAIL)
Test planar constructed NV12 VideoFrame: FAIL (Chrome: FAIL, Safari: FAIL)
Test planar constructed RGB VideoFrames: FAIL (Chrome: FAIL, Safari: FAIL)
Test VideoFrame constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Test we can construct a VideoFrame from an offscreen canvas.: FAIL (Chrome: PASS, Safari: FAIL)
Test I420A VideoFrame and alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test RGBA, BGRA VideoFrames with alpha={keep,discard}: FAIL (Chrome: PASS, Safari: FAIL)
Test a VideoFrame constructed from canvas can drop the alpha channel.: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/videoFrame-copyTo.any.html
Test I420 frame.: FAIL (Chrome: PASS, Safari: FAIL)
Test RGBA frame.: FAIL (Chrome: PASS, Safari: FAIL)
Test undersized buffer.: FAIL (Chrome: FAIL, Safari: FAIL)
Test incorrect plane count.: FAIL (Chrome: FAIL, Safari: FAIL)
Test stride and offset work.: FAIL (Chrome: PASS, Safari: FAIL)
Test stride and offset with padding.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid stride.: FAIL (Chrome: FAIL, Safari: FAIL)
Test address overflow.: FAIL (Chrome: FAIL, Safari: FAIL)
Test codedRect.: FAIL (Chrome: PASS, Safari: FAIL)
Test empty rect.: FAIL (Chrome: PASS, Safari: FAIL)
Test unaligned rect.: FAIL (Chrome: PASS, Safari: FAIL)
Test left crop.: FAIL (Chrome: FAIL, Safari: FAIL)
Test invalid rect.: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/videoFrame-copyTo.any.worker.html
Test I420 frame.: FAIL (Chrome: PASS, Safari: FAIL)
Test RGBA frame.: FAIL (Chrome: PASS, Safari: FAIL)
Test undersized buffer.: FAIL (Chrome: FAIL, Safari: FAIL)
Test incorrect plane count.: FAIL (Chrome: FAIL, Safari: FAIL)
Test stride and offset work.: FAIL (Chrome: PASS, Safari: FAIL)
Test stride and offset with padding.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid stride.: FAIL (Chrome: FAIL, Safari: FAIL)
Test address overflow.: FAIL (Chrome: FAIL, Safari: FAIL)
Test codedRect.: FAIL (Chrome: PASS, Safari: FAIL)
Test empty rect.: FAIL (Chrome: PASS, Safari: FAIL)
Test unaligned rect.: FAIL (Chrome: PASS, Safari: FAIL)
Test left crop.: FAIL (Chrome: FAIL, Safari: FAIL)
Test invalid rect.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9244a4ca3051 [wpt PR 29534] - [webcodecs] Replace ConstraintError., a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.