1718748 - [Ubuntu] Changing to dark theme mode makes the customization footer buttons visible only after mouse hover

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Giorgia Nichita, Release Desktop QA]

Attachment: Peek 2021-06-30 13-34.gif

Affected versions:

• Nightly 91.0a1

Affected platforms:

• Ubuntu 20.04.2 LTS

Unaffected platforms:

• Windows 10x64
• macOs 10.15

Steps to reproduce:

1. Launch Firefox.
2. Go to Customize toolbar (Hamburger menu → More tools → Customize toolbar).
3. On the lower part of the page click on the Themes button and select Dark theme from the list.

Expected result:
All customization footer buttons are clearly visible.

Actual result:
Customization footer buttons are not visible until you hover over them.

Regression range:
This is a regression:

• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=152fdda295bb5f6658d65c2bc48bc6aae499b526&tochange=b873d938120e2cfac6ba3332c663b503dc45d17e
• possible regressor: Bug 1717077

Additional notes
Screen cast attached to observe the issue.

Comment 1

[Giorgia Nichita, Release Desktop QA]

Hi Emilio,

It seems that mozregression pointed out Bug 1717077 for causing this regression.

Can you please take a look?

Thanks!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1717077

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1718748 - Ensure that changing browser.theme.toolbar-theme triggers an style/layout update. r=stransky,mstange

Otherwise nothing invalidates for the potential theme change that it
causes on GTK / macOS with dark-mode enabled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc079cbb02ff
Ensure that changing browser.theme.toolbar-theme triggers an style/layout update. r=stransky

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/bc079cbb02ff

Comment 6

[Oana Botisan, Desktop QA]

Attachment: imgpsh_fullsize_anim.gif

I managed to reproduce the issue using Nightly from 2021-06-30 on Ubuntu 18.04 x64.
I retested everything on Latest Nightly 92.0a1 and Firefox 91.0b7 using the same os. The issue is not reproducing anymore. However there is a bit of a delay on beta that is not reproducing on Nightly.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

That is expected in beta since beta doesn't have the patches here.

Comment 8

[Oana Botisan, Desktop QA]

According to comment 6 and comment 7 I will mark this bug as verified fixed.