1718786 - Dialog windows too tall on when opened on low-DPI secondary screen

Status: RESOLVED WORKSFORME

(Core :: Widget: Win32, defect, P3)

Description

[Virgo Pärna]

Attachment: firefox_about.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

I have laptop with 4K display (3840x2160) (240 dpi) with external 1200p display (1920x1200) (96 dpi) connected.

Actual results:

When Firefox main window is on secondary display, then dialog windows (master password prompt; Help, About Firefox) show up too high (with white bar at the bottom in case of About Firefox window.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Win32' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Florencia Di Ciocco, NI to vbalducci]

Hi, I was able to reproduce this bug in release with a normal screen, though it wasn't as pronounced. Nonetheless, this is not present on nightly, so it's going to the fix will migrate to release soonish.

Regards, Flor.

Comment 3

[Florencia Di Ciocco, NI to vbalducci]

Attachment: nightly vs release

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 5

[Virgo Pärna]

Still in 90.0

Comment 6

[Florencia Di Ciocco, NI to vbalducci]

As you can see on the official calendar, the fix will reach release on the fifth of agust: https://wiki.mozilla.org/Release_Management/Calendar

Comment 7

[Virgo Pärna]

Well, according to the tracking flags, it is still unknown, if version 90 is affected or not.

Comment 8

[Virgo Pärna]

91.0.2 still has same bug.

Comment 9

[Virgo Pärna]

Still in version 92.0

Comment 10

[Virgo Pärna]

Attachment: firefox_about_92.png

Picture showing same issue in version 92.

Comment 11

[Virgo Pärna]

Still in 93.0

Comment 12

[Virgo Pärna]

98.0.2 is still affected. And Master password prompt seems to also be affected. With Firefox windows on lowDPI screen master password prompt is abnormally high, when it shows up on lowdpi screen. When it happens to appear on highdpi screen, then it is fine. IK got a feeling, that when calculating window height, calculates height of upper titlebar as it is on HighDPI screen.

Comment 13

[Virgo Pärna]

102.0.1 is still affected.

Comment 14

[Ray Kraesig [:rkraesig]]

I can reproduce this in the current nightly. Reopening.

Comment 15

[Virgo Pärna]

Seems to work in 107.0.1

Comment 16

[Ray Kraesig [:rkraesig]]

Excellent! And confirmed in v108, as well as a nightly build from a few days ago.

(This is probably fallout from other multimonitor DPI work such as bug 1797170.)