Closed Bug 17188 Opened 25 years ago Closed 25 years ago

Should NSPR automatically set the SO_KEEPALIVE socket option on a new TCP socket?

Categories

(NSPR :: NSPR, defect, P3)

Product:
NSPR
Component:
NSPR
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

Proposed patch. Please review.
5.04 KB, patch
Details | Diff | Splinter Review 
When NSPR creates or imports a new TCP socket, it
automatically sets the SO_KEEPALIVE socket option.
This is done in PR_NewTCPSocket, PR_ImportTCPSocket,
PR_Accept, etc.

Should we do this?  I think we should not.  This is
a decision that should be left for the application
to make.
The keepalive option shouldn't be set automatically.

    
    

    
  
The patch looks good.

    
  
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED

    
    

    
  
The patch is checked in.

Modified files:
pr/include/md/_beos.h
pr/include/md/_os2.h
pr/include/md/_unixos.h
pr/include/md/_win16.h
pr/include/md/_win95.h
pr/include/md/_winnt.h
pr/src/io/prsocket.c
pr/src/pthreads/ptio.c

The patch is also checked into the internal repository (/m/src).

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: