1718860 - Can’t access property, button is null errors in browser console when entering or exiting customize page

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: Screenshot from 2021-07-01 15-56-50 (1).png

Affected versions

• 91.0a1 (20210630212829)

Affected platforms

• Ubuntu 21.04
• Windows 10x64
• macOS 11

Steps to reproduce

1. Open Firefox and enter the Customize menu.
2. Change the theme and exit the Customize menu.
3. Enter the Customize menu and observe the browser console.

Expected result

• No errors are displayed.

Actual result

• TypeError: can't access property "setAttribute", button is null errors are displayed.

Regression range

• Last good revision: 12bf2bd03e3046568c962ee6049eda463f1ea42e
  First bad revision: ab936b7f0c9f9e0b27e42e3f7909131bface08b9
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=12bf2bd03e3046568c962ee6049eda463f1ea42e&tochange=ab936b7f0c9f9e0b27e42e3f7909131bface08b9

Notes

• Attached a screenshot with the issue.

Comment 1

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: console-export-2021-7-1_15-49-44.txt

Attaching the console log as well.

Comment 2

[Kajal Sah]

Attachment: Bug 1718860 - Adds null check for button. r?emalysz,sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6245180c2c4a
Adds null check for button. r=emalysz

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6245180c2c4a

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 91.0a1 (20210706094632) on Windows 10x64, macOS 11.4 and Ubuntu 20.04. No errors are displayed when following the above STR.