Closed Bug 1718864 Opened 3 years ago Closed 3 years ago

Crash in [@ mozilla::dom::BrowsingContext::CrossOriginIsolated] with gconversations addon

Categories

(Thunderbird :: General, defect)

Thunderbird 89
Unspecified
All
defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: wsmwk, Unassigned)

Details

(Keywords: crash)

Crash Data

starting with beta 89 and 90 (and just a couple beta 88 crashes)

Crash report: https://crash-stats.mozilla.org/report/index/da63ae3c-8944-43c9-a4f4-3ff200210701

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::BrowsingContext::CrossOriginIsolated docshell/base/BrowsingContext.cpp:1325
1 xul.dll nsGlobalWindowInner::IsSharedMemoryAllowed const dom/base/nsGlobalWindowInner.h:961
2 xul.dll mozilla::dom::SharedMessageBody::Write dom/ipc/SharedMessageBody.cpp:44
3 xul.dll mozilla::dom::MessagePort::PostMessage dom/messagechannel/MessagePort.cpp:356
4 xul.dll mozilla::dom::MessagePort_Binding::postMessage dom/bindings/MessagePortBinding.cpp:189
5 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3298
6 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:512
7 xul.dll Interpret js/src/vm/Interpreter.cpp:3227
8 xul.dll js::RunScript js/src/vm/Interpreter.cpp:396
9 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:544
Severity: -- → S2
Flags: needinfo?(standard8)

There's nothing obvious here as to why this is occurring, though I'd suspect this is potentially e10s/fission related. Maybe some of the changes I've just been doing for the multi-message view will help, but that's just a guess. As far as I know, Conversations is not doing anything special that is dangerous.

Flags: needinfo?(standard8)

Actually, there was something I fixed in the last release of conversations that may have been causing a crash - sometimes clicking the open attachment button would crash. I don't know that it is this stack though, it didn't always happen.

Might just be worth checking back on this in a few weeks.

(In reply to Mark Banner (:standard8) from comment #2)

Actually, there was something I fixed in the last release of conversations that may have been causing a crash - sometimes clicking the open attachment button would crash. I don't know that it is this stack though, it didn't always happen.

Might just be worth checking back on this in a few weeks.

The crash rate is down slightly since July 1 https://crash-stats.mozilla.org/signature/?product=Thunderbird&signature=mozilla%3A%3Adom%3A%3ABrowsingContext%3A%3ACrossOriginIsolated&date=%3E%3D2021-03-07T17%3A31%3A00.000Z&date=%3C2021-09-07T17%3A31%3A00.000Z#graphs

And all the crashes of the past couple weeks are old versions of the addon. Mostly 3.2.17. Sadly, seems some people are stuck on the old version.

FTR the fix was https://github.com/thunderbird-conversations/thunderbird-conversations/commit/423920e317c6605adc53639c85fb4ecf47452e2a

I'm not sure we can do anything about people being stuck on older versions. Conversations didn't have a max version set, so they should be updating.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.