Closed Bug 1718986 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29567 - [wpt] Fix grid-item (no) aspect-ratio tests.

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29567 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29567
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[wpt] Fix grid-item (no) aspect-ratio tests.

Renaming scheme got lost, however basically:

grid-item-no-aspect-ratio-stretch-4.html -> grid-item-aspect-ratio-stretch-1.html
grid-item-no-aspect-ratio-stretch-5.html -> grid-item-aspect-ratio-stretch-2.html
grid-item-no-aspect-ratio-stretch-6.html -> grid-item-aspect-ratio-stretch-3.html
grid-item-no-aspect-ratio-stretch-7.html -> grid-item-aspect-ratio-stretch-4.html

These tests all had a viewBox defining a valid aspect-ratio. Due to:
https://github.com/w3c/csswg-drafts/issues/6286#issuecomment-866986544
These tests should have an aspect-ratio, and when stretched in one
dimension, should reflect to the other dimension (if unconstrained). See:
https://github.com/w3c/csswg-drafts/issues/5713#issuecomment-755791551

The below two tests basically just got renamed:
grid-item-no-aspect-ratio-stretch-8.html -> grid-item-no-aspect-ratio-stretch-4.html
grid-item-no-aspect-ratio-stretch-9.html -> grid-item-no-aspect-ratio-stretch-5.html
grid-item-no-aspect-ratio-stretch-10.html -> grid-item-no-aspect-ratio-stretch-6.html

But tests updated to correctly assert that the natural size would still
be respected.

To all these test-cases I also added "grid-template: 100% / 100%;" as
there is further complexity when inside an auto row/column which is
tested elsewhere.
(Transferred minimum size for replaced elements with an aspect-ratio).

Bug: 1114013
Change-Id: I062f67e291cc62fa63a53370595780dae16abf3b

Reviewed-on: https://chromium-review.googlesource.com/3003564
WPT-Export-Revision: bf21e385d783ae0547a3ea3e554ee43a8beac1d6

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 7 tests

Status Summary

Firefox

FAIL: 7

Chrome

PASS: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-grid/alignment/grid-item-aspect-ratio-stretch-1.html: FAIL (Chrome: PASS)
/css/css-grid/alignment/grid-item-aspect-ratio-stretch-2.html: FAIL (Chrome: PASS)
/css/css-grid/alignment/grid-item-aspect-ratio-stretch-3.html: FAIL (Chrome: PASS)
/css/css-grid/alignment/grid-item-aspect-ratio-stretch-4.html: FAIL (Chrome: PASS)
/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-4.html: FAIL (Chrome: PASS)
/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-5.html: FAIL (Chrome: PASS)
/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-6.html: FAIL (Chrome: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/855ddd9539c4
[wpt PR 29567] - [wpt] Fix grid-item (no) aspect-ratio tests., a=testonly
https://hg.mozilla.org/integration/autoland/rev/e4056c4559cc
[wpt PR 29567] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/855ddd9539c4
https://hg.mozilla.org/mozilla-central/rev/e4056c4559cc

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.