1719011 - <input type=time> does not warn user when submitting with partial value (Chrome does)

Status: VERIFIED FIXED

(Core :: DOM: Forms, defect)

Description

[xuerian]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

Enter a partial time in a time input (Eg: [01:--:AM], a conceptually valid time)

Submit form

Actual results:

Form is submitted with empty value and no warning

Expected results:

Form should not be submitting and a warning should be shown for the input

Comment 1

[xuerian]

Due to #1719010 and #1719007, I can't figure out a work around for this other than onblur="setTimeout(()=>this.value=this.value)"

Chrome correctly warns the user when this happens

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Form Controls' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: test-case

Comment 4

[Emilio Cobos Álvarez (:emilio)]

So on the above test-case in Chrome input.validity.valid is false, and input.validity.badInput is true, which I think makes sense.

This piece of code however seems pretty intentional, and is responsible for us not to get the behavior that chrome has.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

This goes back to https://searchfox.org/mozilla-central/rev/f75b36a5b79da3bb35c8d45fcef4c5f5ec7e3fdd/toolkit/content/widgets/datetimebox.xml#1450-1453 (bug 1372369).

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1719011 - Consider incomplete date/time inputs as "bad input". r=smaug

This matches Chrome.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de4c385b1971
Consider incomplete date/time inputs as "bad input". r=smaug

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/de4c385b1971

Comment 9

[Anca Soncutean, Desktop QA]

Reproduced with Fx 91.0a1 (2021-07-02) on Windows 10.
Verified fixed with Fx 91.0b9 and Fx 92.0a1 (2021-07-29) on Windows 10, macOS 11.0 and Ubuntu 18.04.