1719108 - Intermittent [tier 2] LeakSanitizer | leak at mozilla::CreateMediumHighRunnable, mozilla::image::IDecodingTask::NotifyDecodeComplete, mozilla::image::DecodedSurfaceProvider::FinishDecoding, mozilla::image::DecodedSurfaceProvider::Run

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Treeherder Bug Filer]

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=344309895&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Rck67cjiQiSrROr48r5eew/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-07-04T22:31:52.468Z] 22:31:52     INFO - TEST-START | netwerk/test/browser/browser_post_auth.js
[task 2021-07-04T22:31:54.191Z] 22:31:54     INFO - GECKO(13371) | -----------------------------------------------------
[task 2021-07-04T22:31:54.192Z] 22:31:54     INFO - GECKO(13371) | Suppressions used:
[task 2021-07-04T22:31:54.193Z] 22:31:54     INFO - GECKO(13371) |   count      bytes template
[task 2021-07-04T22:31:54.193Z] 22:31:54     INFO - GECKO(13371) |      14        448 nsComponentManagerImpl
[task 2021-07-04T22:31:54.194Z] 22:31:54     INFO - GECKO(13371) |       2        288 libfontconfig.so
[task 2021-07-04T22:31:54.195Z] 22:31:54     INFO - GECKO(13371) | -----------------------------------------------------
<...>
[task 2021-07-04T22:32:19.348Z] 22:32:19     INFO - GECKO(13371) | -----------------------------------------------------
[task 2021-07-04T22:32:19.426Z] 22:32:19     INFO - TEST-INFO | Main app process: exit 0
[task 2021-07-04T22:32:19.428Z] 22:32:19     INFO - TEST-INFO | LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2021-07-04T22:32:19.429Z] 22:32:19     INFO - TEST-INFO | LeakSanitizer | This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2021-07-04T22:32:19.430Z] 22:32:19    ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::CreateMediumHighRunnable, mozilla::image::IDecodingTask::NotifyDecodeComplete, mozilla::image::DecodedSurfaceProvider::FinishDecoding, mozilla::image::DecodedSurfaceProvider::Run
[task 2021-07-04T22:32:19.431Z] 22:32:19    ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at NS_NewRunnableFunction, mozilla::image::IDecodingTask::NotifyDecodeComplete, mozilla::image::DecodedSurfaceProvider::FinishDecoding, mozilla::image::DecodedSurfaceProvider::Run
[task 2021-07-04T22:32:19.432Z] 22:32:19    ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at already_AddRefed, mozilla::image::SurfaceCacheImpl::ReleaseImageOnMainThread, mozilla::image::SurfaceCache::ReleaseImageOnMainThread, mozilla::image::DecodedSurfaceProvider::Run
[task 2021-07-04T22:32:19.433Z] 22:32:19     INFO - runtests.py | Application ran for: 0:01:10.155459

Comment 1

[Intermittent Failures Robot]

2 failures in 723 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2

Platform and build breakdown:

• linux1804-64-asan: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1719108&startday=2021-06-28&endday=2021-07-04&tree=all

Comment 2

[Andrew McCreight [:mccr8]]

My guess would be that some runnable tried to dispatch to another thread late enough in shutdown, so it failed and we intentionally leaked the runnable.

Comment 3

[Marian-Vasile Laza]

This looks to have appeared after bug 1714299 landed - link.

Andrew, could you please take a look?

Comment 4

[Timothy Nikkel (:tnikkel)]

Are we just supposed to check gXPCOMThreadsShutDown before any dispatch which might be after shutdown? I guess imagelib has a ShutdownTracker::ShutdownHasStarted too, not sure which is better.

Comment 5

[Intermittent Failures Robot]

50 failures in 2387 pushes (0.021 failures/push) were associated with this bug in the last 7 days.

This is the #23 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 34
• mozilla-central: 16

Platform and build breakdown:

• linux1804-64-asan: 50
  • opt: 50

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1719108&startday=2021-07-05&endday=2021-07-11&tree=all

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Timothy Nikkel (:tnikkel) from comment #4)

Are we just supposed to check gXPCOMThreadsShutDown before any dispatch which might be after shutdown? I guess imagelib has a ShutdownTracker::ShutdownHasStarted too, not sure which is better.

I don't think that's common, and these sorts of leaks are usually quite rare. I don't know why the frequency is so high for these image runnables. That probably is the easiest fix here.

Comment 7

[Timothy Nikkel (:tnikkel)]

(In reply to Andrew McCreight [:mccr8] from comment #6)

(In reply to Timothy Nikkel (:tnikkel) from comment #4)

Are we just supposed to check gXPCOMThreadsShutDown before any dispatch which might be after shutdown? I guess imagelib has a ShutdownTracker::ShutdownHasStarted too, not sure which is better.

I don't think that's common, and these sorts of leaks are usually quite rare. I don't know why the frequency is so high for these image runnables. That probably is the easiest fix here.

I think because bug 1714299 landed a test that loads an image and the test happens to run right at the end of the chunk so we are in the middle of decoding the image and shutdown happens very quickly for some reason.

Comment 8

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1719108. Check in a few places in imagelib if it's too late in shutdown to dispatch runnables. r?mccr8

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4efdd0314268
Check in a few places in imagelib if it's too late in shutdown to dispatch runnables. r=mccr8

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4efdd0314268

Comment 11

[Intermittent Failures Robot]

22 failures in 2224 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 19
• mozilla-central: 3

Platform and build breakdown:

• linux1804-64-asan: 22
  • opt: 22

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1719108&startday=2021-07-12&endday=2021-07-18&tree=all