1719146 - Compile error with newer linux kernel.

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

On a Fedora Rawhide machine:

 0:03.49 /home/emilio/src/moz/gecko-2/toolkit/crashreporter/breakpad-client/linux/handler/exception_handler.cc:151:41: error: no matching function for call to 'max'
 0:03.49   static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);
 0:03.49                                         ^~~~~~~~
 0:03.49 /usr/lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/bits/algorithmfwd.h:407:5: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('int' vs. 'long')
 0:03.49     max(const _Tp&, const _Tp&);
 0:03.49     ^
 0:03.49 /usr/lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/bits/stl_algo.h:3467:5: note: candidate template ignored: could not match 'initializer_list<type-parameter-0-0>' against 'int'
 0:03.49     max(initializer_list<_Tp> __l, _Compare __comp)
 0:03.49     ^
 0:03.49 /usr/lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/bits/stl_algo.h:3461:5: note: candidate function template not viable: requires single argument '__l', but 2 arguments were provided
 0:03.49     max(initializer_list<_Tp> __l)
 0:03.49     ^
 0:03.49 /usr/lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/bits/algorithmfwd.h:412:5: note: candidate function template not viable: requires 3 arguments, but 2 were provided
 0:03.49     max(const _Tp&, const _Tp&, _Compare);

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1719146 - Use size_t in breakpad's Linux exception handler. r=gsvelto

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01d1b354a1fa
Use size_t in breakpad's Linux exception handler. r=gsvelto

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/01d1b354a1fa