Closed
Bug 1719160
Opened 3 years ago
Closed 3 years ago
checkValue commands test helpers are not properly checking undefined values
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox91 fixed)
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
if the value we want to check is undefined, we won't check that it's what we expect: https://searchfox.org/mozilla-central/rev/b7bc94b4689a7f002c61d016c6e162e5e5708bf3/devtools/shared/commands/resource/tests/head.js#94-95
|
Assignee | |
Comment 1•3 years ago
|
||
We weren't checking properly undefined value, which was hiding issues in
some tests.
The helpers are fixed and a few test modified to make them pass.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34f5f140fac0 [devtools] Fix checkValue commands test helper. r=jdescottes.
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•