Closed Bug 1719256 Opened 3 years ago Closed 3 years ago

TestHighlighterActor should not require to explicitly pass around the inspector actor ID

Categories

(DevTools :: Inspector, task, P3)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(1 file)

For a few APIs, the test highlighter actor expects consumers to provide the inspector actor ID.

This makes no sense since the highlighter actor is a target scoped actor and can only be linked to a single inspector actor.

The issue is actually that on the server side, the test highlighter actor has no way to "find" the correct inspector actor unless it knows its ID. However we can make it so that the test highlighter front sets this up automatically when initializing and then it will avoid doing it in each and every test.

The Bugbug bot thinks this bug should belong to the 'DevTools::Inspector' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Inspector
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a39feedfa09a
[devtools] initialize HighlighterTestActor with the correct inspector ID r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: