171931 - Crash deleting incompatible themes [@ nsChromeRegistry::OverlaysAllowedForPackage] [@ _PR_NativeRunThread]

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[greer]

We have a lot of folks crashing while trying to uninstall outdated themes.
Starting in Trunk builds from the 24th. 

hyatt checked in to nsChromeRegistry.cpp on the 23rd, cc'ing him.
Looks like we need some more spackle.

	 nsChromeRegistry::OverlaysAllowedForPackage
[c:/builds/seamonkey/mozilla/rdf/chrome/src/nsChromeRegistry.cpp  line 2668]
	 XPTC_InvokeByIndex
[c:/builds/seamonkey/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp 
line 106]
	 XPCWrappedNative::CallMethod
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp  line 1996]
	 XPC_WN_CallMethod
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp 
line 1267]
	 js_Invoke	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 841]
	 js_Interpret	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 2804]
	 js_Invoke	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 857]
	 js_InternalInvoke	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 932]
	 JS_CallFunctionValue	[c:/builds/seamonkey/mozilla/js/src/jsapi.c  line 3433]
	 nsJSContext::CallEventHandler
[c:/builds/seamonkey/mozilla/dom/src/base/nsJSEnvironment.cpp  line 1044]
	 nsJSEventListener::HandleEvent
[c:/builds/seamonkey/mozilla/dom/src/events/nsJSEventListener.cpp  line 184]
	 nsEventListenerManager::HandleEventSubType
[c:/builds/seamonkey/mozilla/content/events/src/nsEventListenerManager.cpp  line
1183]
	 nsEventListenerManager::HandleEvent
[c:/builds/seamonkey/mozilla/content/events/src/nsEventListenerManager.cpp  line
2171]
	 nsXULElement::HandleDOMEvent
[c:/builds/seamonkey/mozilla/content/xul/content/src/nsXULElement.cpp  line 3470]
	 nsXULElement::HandleDOMEvent
[c:/builds/seamonkey/mozilla/content/xul/content/src/nsXULElement.cpp  line 3489]
	 nsXULElement::HandleDOMEvent
[c:/builds/seamonkey/mozilla/content/xul/content/src/nsXULElement.cpp  line 3489]
	 nsXULElement::HandleDOMEvent
[c:/builds/seamonkey/mozilla/content/xul/content/src/nsXULElement.cpp  line 3489]
	 nsXULElement::HandleDOMEvent
[c:/builds/seamonkey/mozilla/content/xul/content/src/nsXULElement.cpp  line 3489]
	 PresShell::HandleDOMEventWithTarget
[c:/builds/seamonkey/mozilla/layout/html/base/src/nsPresShell.cpp  line 6268]
	 nsMenuFrame::Execute
[c:/builds/seamonkey/mozilla/layout/xul/base/src/nsMenuFrame.cpp  line 1696]
	 nsMenuFrame::HandleEvent
[c:/builds/seamonkey/mozilla/layout/xul/base/src/nsMenuFrame.cpp  line 464]
	 PresShell::HandleEventInternal
[c:/builds/seamonkey/mozilla/layout/html/base/src/nsPresShell.cpp  line 6237]
	 PresShell::HandleEvent
[c:/builds/seamonkey/mozilla/layout/html/base/src/nsPresShell.cpp  line 6143]
	 nsViewManager::HandleEvent
[c:/builds/seamonkey/mozilla/view/src/nsViewManager.cpp  line 2121]
	 nsView::HandleEvent	[c:/builds/seamonkey/mozilla/view/src/nsView.cpp  line 301]
	 nsViewManager::DispatchEvent
[c:/builds/seamonkey/mozilla/view/src/nsViewManager.cpp  line 1932]
	 HandleEvent	[c:/builds/seamonkey/mozilla/view/src/nsView.cpp  line 83]
	 nsWindow::DispatchEvent
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 1043]
	 nsWindow::DispatchWindowEvent
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 1060]
	 nsWindow::DispatchMouseEvent
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 5242]
	 ChildWindow::DispatchMouseEvent
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 5497]
	 nsWindow::ProcessMessage
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 4028]
	 nsWindow::WindowProc
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 1309]
	 USER32.dll + 0x3a5f (0x77d43a5f)
	 USER32.dll + 0x3b2e (0x77d43b2e)
	 USER32.dll + 0x3d6a (0x77d43d6a)
	 USER32.dll + 0x41fd (0x77d441fd)
	 nsAppShellService::Run
[c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp  line 472]
	 main1	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1538]
	 main	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1886]
	 WinMain	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1906]
	 WinMainCRTStartup()
	 kernel32.dll + 0x1eb69 (0x77e7eb69)
 
 	Source File : c:/builds/seamonkey/mozilla/rdf/chrome/src/nsChromeRegistry.cpp
line : 2668
     (11837703)	Comments: tried to select another skin other than default and it
shut down
     (11832192)	URL:
ftp://ftp.ibiblio.org/pub/Linux/distributions/contrib/texstar/Mandrake-8.2/RPMS/
     (11822979)	URL: broadband.zoomtown.com
     (11822979)	Comments: I was unistalling Orbit theme because it does not work.
     (11818368)	URL: http://www.libertynet.org/ntr/Bookmarks.html
     (11818368)	Comments: loading outdated theme  
     (11788208)	URL:
ftp://ftp.ibiblio.org/pub/Linux/distributions/contrib/texstar/Mandrake-8.2/RPMS/
     (11746030)	URL: http://mozilla.com
     (11746030)	Comments: Switching to an unsupported theme. It reported that
the theme was for an older version and then created an error report.  
     (11712496)	URL: Trying to delete skin that may have caused last crash.
     (11712496)	Comments: Trying to delete skin that may have caused last crash.
crashes every time i try to delete skin. I did get a warning this time that said
this skin was developed for an earlier version of Mozilla and not compatible.
and to delete it. will not delete.
     (11712315)	URL: Trying to delete skin that may have caused last crash.
     (11712252)	URL: Trying to delete skin that may have caused last crash.
     (11712140)	URL: Trying to change skin.
     (11692603)	Comments: i changed the theme and mozilla crashed
     (11675663)	Comments: Installeded 9/27 08 build over older build  changed
theme to non-1.2b compliant Pinball theme and bam we crashed.
     (11673632)	Comments: tried to uninstall themes that no longer work!
     (11673557)	Comments: cant start it after a crash with a theme iuuninstall
     (11622349)	Comments: trying to change themes..  the browser crashed....
     (11605717)	Comments: attempting to load outdated theme (orbit 3+1 current
stable version and devel version)
     (11594540)	URL: http://myyahoo.yahoo.com
     (11530865)	URL: www.deskmod.com

Comment 1

[greer]

The same browser behavior is crashing here:

Stack Trace:   
_PR_NativeRunThread [pruthr.c line 457]   
 msvcrt.dll + 0x27fb8 (0x77c37fb8)    
kernel32.dll + 0x202ed (0x77e802ed)

Adding that sig into the summary for the Talkback automation.

Comment 2

[greer]

*** Bug 171893 has been marked as a duplicate of this bug. ***

Comment 3

[greer]

Bug 171893 listed these steps to reproduce (using the 20020930 trunk build on W2K):

Steps to Reproduce:
Install
1. Download a version 1.1 theme from Deskmod
2. Confirm download and installation

Uninstall
1. Edit|Preferences|Themes
2. Select version 1.1 theme to uninstall
3. Press Uninstall button
or
1. View|Apply Theme|<Theme name>
   Mozilla warns about old theme and gives option to uninstall by pressing OK
2. Press OK button

Comment 4

[David Hyatt]

OverlaysAllowedForPackage is never called from script in Mozilla, so this stack has been trashed.  Not sure what the real crash is, but it isn't OverlaysAllowedForPackage.

Comment 5

[Brendan Eich [:brendan]]

hyatt, did you add methods to the middle of an interface?

/be

Comment 6

[Jan Carpenter]

1 instance of _PR_NativeRunThread in august 2002, and no instances at all of
nsChromeRegistry::OverlaysAllowedForPackage in the talkback database.  Marking
fixed.

Reopen as needed, etc.