Preference tab empty when building with MOZ_UPDATER unset
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird_esr78 unaffected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
People
(Reporter: zoe, Assigned: mkmelin)
Details
(Keywords: regression)
Attachments
(1 file)
Filing this for better visibility, see bug 1703164 comment #20 for details.
|
Reporter | |
Updated•3 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
I don't think this regressed by bug 1703164 (which only changed the "format").
|
|
Assignee | |
Updated•3 years ago
|
|
|
Reporter | |
Comment 3•3 years ago
|
||
Fixes the issue, thanks. Sorry about the wrong regressor, we were looking for code in the context of that define. Could you explain the fix? XPCOMUtils is also used here
https://searchfox.org/comm-central/rev/89f957706bbda77e5f34e64e117e7ce121bb5d83/mail/components/preferences/preferences.js#37
which is where the "not defined" error came from, but not loaded in that file. Adding it there leads to more errors of "multiple define" (not sure now).
|
|
Assignee | |
Comment 4•3 years ago
|
||
I added the import instead of relying on it being already imported from some earlier included .js file.
You should be able to import it as many times as you want as long as you use var, not let/const. It will really just import it the first time time and for the times after that only check that it's loaded - but not do any work.
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/abae17fede8d
make sure XPCOMUtils is imported also with MOZ_UPDATER unset. r=lasana
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/afbd33d32ef3 follow-up - Fix broken tests. rs=bustage-fix
Description
•