1719413 - Implement nsINntpService in JavaScript

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, task)

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Init NntpModuleLoader.jsm and NntpService.jsm to start implementing NNTP in JS. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/822bad975580
Init NntpModuleLoader.jsm and NntpService.jsm to start implementing NNTP in JS. r=mkmelin

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Init NntpProtocolHandler.jsm and NntpChannel.jsm. r=mkmelin

This is the initial step to fetch and render a news article.

Depends on D120192.

Comment 4

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Support fetching and rendering a single article in NntpChannel.jsm. r=mkmelin

Implement the asyncOpen method in NntpChannel.jsm, and connect it with NntpClient.jsm.

Depends on D120822.

Comment 5

[Geoff Lankow (:darktrojan)]

D121593 doesn't apply cleanly, and I'd rather not attempt to rebase it myself.

Comment 6

[Ping Chen [:rnons] (away)]

(In reply to Geoff Lankow (:darktrojan) from comment #5)

D121593 doesn't apply cleanly, and I'd rather not attempt to rebase it myself.

Forgot to set checkin-needed-tb in bug 1719414, apply in this order D120192, D120822, D121593.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/203e693fb0f9
Init NntpProtocolHandler.jsm and NntpChannel.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/b02dbe764d52
Support fetching and rendering a single article in NntpChannel.jsm. r=mkmelin

Comment 8

[Geoff Lankow (:darktrojan)]

Thanks, I would've found that out if I'd actually looked at the stack in Phabricator. :-/

Comment 9

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Implement postMessage in NntpService.jsm. r=mkmelin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d237097fbf39
Implement postMessage in NntpService.jsm. r=mkmelin

Comment 11

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Use memory cache in NntpChannel.jsm if available. r=mkmelin

When fetching an article from the server, use a nsIStreamListenerTee to save to the memory cache. When loading the message for a second time, read from the memory cache without asking the server.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7571a9fe8007
Use memory cache in NntpChannel.jsm if available. r=mkmelin

Comment 13

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Enable test_nntpProtocols.js for SmtpService.jsm. r=mkmelin

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/42360175507e
Enable test_nntpProtocols.js for SmtpService.jsm. r=mkmelin

Comment 15

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Add a getSlicedOfflineFileStream function to nsIMsgFolder. r=mkmelin

Because new SlicedInputStream is not available in JS, but to read a single message from offline storage, we must use a sliced stream.

Comment 16

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Enable test_bug170727.js for nntp-js. r=mkmelin

Support offline storage for news messages.

Depends on D125801.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/396cff769c05
Add a getSlicedOfflineFileStream function to nsIMsgFolder. r=mkmelin
https://hg.mozilla.org/comm-central/rev/f8a9cb9b814b
Enable test_bug170727.js for nntp-js. r=mkmelin

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/848f5e66190e
Enable test_bug170727.js for nntp-js. r=mkmelin

Comment 19

[Magnus Melin [:mkmelin]]

(the original landing of f8a9cb9b814b was backed out, then relanded)

Looks like debug xpshell tests are all crashing or causing lots of problems though.

Comment 20

[Magnus Melin [:mkmelin]]

Backout: https://hg.mozilla.org/comm-central/rev/58181ec3bef73323955fb1895c8e8296fc77a41f

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/93ce7c1076e7
Enable test_bug170727.js for nntp-js. r=mkmelin

Comment 22

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Enable test_internalUris.js for nntp-js. r=mkmelin

• Implement fetchMessage/cancelMessage of nsINntpService
• Implement nsIMsgMessageService.Search

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/40d0a68df717
Enable test_internalUris.js for nntp-js. r=mkmelin

Comment 24

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Add NntpProtocolInfo.jsm to implement nsIMsgProtocolInfo. r=mkmelin

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0471e9aac1d0
Add NntpProtocolInfo.jsm to implement nsIMsgProtocolInfo. r=mkmelin

Comment 26

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Handle server charset in nntp-js. r=mkmelin

Use folder.rawName as group name when communicating with NNTP server.

Depends on D128583.

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5f00e345540f
Handle server charset in nntp-js. r=mkmelin

Comment 28

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Enable nntp-js (mailnews.nntp.jsmodule=true). r=mkmelin

Comment 29

[Magnus Melin [:mkmelin]]

After a bunch of real world testing I found some problems (didn't verify if they are nntp-js only):

• Set up a new nntp account, in the console I got
  TypeError: can't access property "folderURL", parentFolder is nullMailNotificationService.jsm:335:51
  onFolderAdded resource:///modules/MailNotificationService.jsm:335
  finishAccount chrome://messenger/content/AccountWizard.js:330
  FinishAccount chrome://messenger/content/AccountWizard.js:181
  _fireEvent chrome://global/content/elements/wizard.js:471
  advance chrome://global/content/elements/wizard.js:294
  listeners chrome://global/content/elements/wizard.js:523
  openNewsgroupAccountWizard chrome://messenger/content/accountUtils.js:95
  oncommand chrome://messenger/content/messenger.xhtml:1

• In the subscription dialog, the Current group list is not showing when one opens the dialog. It does show up if I click Refresh.

• Newsgroups showing empty To in header (should be hidden)

• In a profile where I had a ddt.demos.su account set up already (with one newsgroup subscribed), the FIRST time I tried to access it I got the error below (After restart it seems to work though...)
  TypeError: can't access property "withClient", server.wrappedJSObject is undefined NntpService.jsm:100:5
  getNewNews resource:///modules/NntpService.jsm:100
  updateFolderAndNotifyOnLoad resource:///modules/DBViewWrapper.jsm:88
  open resource:///modules/DBViewWrapper.jsm:810
  show chrome://messenger/content/folderDisplay.js:849
  FolderPaneSelectionChange chrome://messenger/content/commandglue.js:363
  onselect chrome://messenger/content/messenger.xhtml:1
  MozTreeChildren chrome://global/content/elements/tree.js:69

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/941a98642b38
Fix server.prettyName and news groups searching. r=mkmelin

Comment 31

[Magnus Melin [:mkmelin]]

Empty To is bug 1739090.

Comment 32

[Ping Chen [:rnons] (away)]

(In reply to Magnus Melin [:mkmelin] from comment #29)

After a bunch of real world testing I found some problems (didn't verify if they are nntp-js only):

• Set up a new nntp account, in the console I got
  TypeError: can't access property "folderURL", parentFolder is nullMailNotificationService.jsm:335:51

Yes, this also happens after creating a mail account, I think it's related to some msgfolder code changes.

• In the subscription dialog, the Current group list is not showing when one opens the dialog. It does show up if I click Refresh.

I can't reproduce this, I tried using the cpp backend to create 2 newsgroup accounts and fetch the group list. After I change the pref to use jsm and restart, the group list is still there.

• In a profile where I had a ddt.demos.su account set up already (with one newsgroup subscribed), the FIRST time I tried to access it I got the error below (After restart it seems to work though...)
  TypeError: can't access property "withClient", server.wrappedJSObject is undefined NntpService.jsm:100:5

I can't reproduce this as well, the server is being passed to NntpService.getNewNews(). This error can happen only if using NntpService.jsm together with nsNntpIncomingServer.cpp, I guess something failed in that particular startup and messed module registration.

Comment 33

[Magnus Melin [:mkmelin]]

Ok. Can't reproduce the group list problem either now. Potentially just slow network at the time.

Comment 34

[Ping Chen [:rnons] (away)]

Attachment: Bug 1719413 - Enable nntp-js (mailnews.nntp.jsmodule=true). r=mkmelin

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a1975b7e4cdb
Enable nntp-js (mailnews.nntp.jsmodule=true). r=mkmelin