HP-UX ia64 should not export __shlInit

RESOLVED FIXED

Status

SeaMonkey
Build Config
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: Jim Dunn, Assigned: Jim Dunn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

772 bytes, patch
hacker formerly known as seawood@netscape.com
: review+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
The aCC compiler for ia64 (HP-UX 11.20) doesn't require __shlInit
to be exported for a sharedLibrary (IS_COMPONENT=1) the way
HP_UX 10.20 & 11.00 require it.  In fact it issues a warning if
you try.
(Assignee)

Comment 1

16 years ago
Created attachment 101276 [details] [diff] [review]
for HP-UX ia64 don't export __shlInit from a Component

NOTE: this is ifdef'd already for HP-UX so is a very harmless fix
Comment on attachment 101276 [details] [diff] [review]
for HP-UX ia64 don't export __shlInit from a Component

You could have avoided duplicating those flags by just checking for the ifneq
but this patch'll work. r=cls
Attachment #101276 - Flags: review+
(Assignee)

Comment 3

16 years ago
Created attachment 101289 [details] [diff] [review]
updated patch to reflect cls's comments

Same basic patch but simpler
(Assignee)

Comment 4

16 years ago
Comment on attachment 101276 [details] [diff] [review]
for HP-UX ia64 don't export __shlInit from a Component

subsequent patch is better
Attachment #101276 - Attachment is obsolete: true
Comment on attachment 101289 [details] [diff] [review]
updated patch to reflect cls's comments

r=cls
Attachment #101289 - Flags: review+
(Assignee)

Comment 6

16 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Summary: HP-UX ia64 should not export __shlInit → HP-UX ia64 should not export __shlInit
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.