Closed Bug 1719567 Opened 3 years ago Closed 3 years ago

Permanent [Tier 2] devtools/client/netmonitor/test/browser_net_search-results.js | Node is not focusable via the accessibility API: id: /server0.conn125.netEvent27/0, tagName: TR, className: treeRow resultRow -

Categories

(DevTools :: Netmonitor, defect, P5)

defect

Tracking

(firefox-esr78 unaffected, firefox89 unaffected, firefox90 unaffected, firefox91 fixed, firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox89 --- unaffected
firefox90 --- unaffected
firefox91 --- fixed
firefox92 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: sebo)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disable-recommended])

Attachments

(1 file)

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=344624525&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IbiI7t-HRPObgBsHw18qlA/runs/0/artifacts/public/logs/live_backing.log


[task 2021-07-07T21:37:10.990Z] 21:37:10     INFO - TEST-START | devtools/client/netmonitor/test/browser_net_search-results.js
[task 2021-07-07T21:37:12.185Z] 21:37:12     INFO - TEST-INFO | started process screentopng
[task 2021-07-07T21:37:12.463Z] 21:37:12     INFO - TEST-INFO | screentopng: exit 0
[task 2021-07-07T21:37:12.465Z] 21:37:12     INFO - Buffered messages logged at 21:37:10
[task 2021-07-07T21:37:12.466Z] 21:37:12     INFO - Entering test bound 
[task 2021-07-07T21:37:12.467Z] 21:37:12     INFO - Buffered messages logged at 21:37:11
[task 2021-07-07T21:37:12.468Z] 21:37:12     INFO - Initializing a network monitor pane.
[task 2021-07-07T21:37:12.469Z] 21:37:12     INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/netmonitor/test/html_custom-get-page.html
[task 2021-07-07T21:37:12.470Z] 21:37:12     INFO - Tab added and finished loading
[task 2021-07-07T21:37:12.474Z] 21:37:12     INFO - Net tab added successfully: http://example.com/browser/devtools/client/netmonitor/test/html_custom-get-page.html
[task 2021-07-07T21:37:12.475Z] 21:37:12     INFO - Network monitor pane shown successfully.
[task 2021-07-07T21:37:12.476Z] 21:37:12     INFO - Disabling cache and reloading page.
[task 2021-07-07T21:37:12.477Z] 21:37:12     INFO - Got marker: dom-interactive
[task 2021-07-07T21:37:12.477Z] 21:37:12     INFO - Got marker: dom-complete
[task 2021-07-07T21:37:12.479Z] 21:37:12     INFO - Got two timeline markers, done waiting
[task 2021-07-07T21:37:12.481Z] 21:37:12     INFO - > Network event progress: NetworkEvent: 0/1, PayloadReady: 1/1, EventTimings: 0/0, got NetMonitor:PayloadReady for server0.conn125.netEvent8
[task 2021-07-07T21:37:12.482Z] 21:37:12     INFO - > Network event progress: NetworkEvent: 1/1, PayloadReady: 1/1, EventTimings: 0/1, got NetMonitor:NetworkEvent for server0.conn125.netEvent8
[task 2021-07-07T21:37:12.483Z] 21:37:12     INFO - Console message: [JavaScript Warning: "Relative positioning of table rows and row groups is now supported. This site may need to be updated because it may depend on this feature having no effect." {file: "resource://devtools/client/netmonitor/src/components/request-list/RequestListHeader.js" line: 545}]
[task 2021-07-07T21:37:12.483Z] 21:37:12     INFO - > Network event progress: NetworkEvent: 1/1, PayloadReady: 1/1, EventTimings: 1/1, got NetMonitor:NetworkEventUpdated:EventTimings for server0.conn125.netEvent8
[task 2021-07-07T21:37:12.483Z] 21:37:12     INFO - Clearing requests in the UI.
[task 2021-07-07T21:37:12.483Z] 21:37:12     INFO - Starting test... 
[task 2021-07-07T21:37:12.484Z] 21:37:12     INFO - Console message: [JavaScript Warning: "Cookie “name1” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "http://example.com/browser/devtools/client/netmonitor/test/sjs_search-test-server.sjs?value=test1" line: 0}]
[task 2021-07-07T21:37:12.486Z] 21:37:12     INFO - Console message: [JavaScript Warning: "Cookie “name1” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "http://example.com/browser/devtools/client/netmonitor/test/sjs_search-test-server.sjs?value=test1" line: 0}]
[task 2021-07-07T21:37:12.487Z] 21:37:12     INFO - Console message: [JavaScript Warning: "Cookie “name1” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "http://example.com/browser/devtools/client/netmonitor/test/sjs_search-test-server.sjs?value=test2" line: 0}]
[task 2021-07-07T21:37:12.488Z] 21:37:12     INFO - Console message: [JavaScript Warning: "Cookie “name1” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "http://example.com/browser/devtools/client/netmonitor/test/sjs_search-test-server.sjs?value=test2" line: 0}]
[task 2021-07-07T21:37:12.507Z] 21:37:12     INFO - > Network event progress: NetworkEvent: 0/2, PayloadReady: 1/2, EventTimings: 0/0, got NetMonitor:PayloadReady for server0.conn125.netEvent27
[task 2021-07-07T21:37:12.508Z] 21:37:12     INFO - > Network event progress: NetworkEvent: 0/2, PayloadReady: 2/2, EventTimings: 0/0, got NetMonitor:PayloadReady for server0.conn125.netEvent47
[task 2021-07-07T21:37:12.509Z] 21:37:12     INFO - > Network event progress: NetworkEvent: 1/2, PayloadReady: 2/2, EventTimings: 0/1, got NetMonitor:NetworkEvent for server0.conn125.netEvent27
[task 2021-07-07T21:37:12.509Z] 21:37:12     INFO - > Network event progress: NetworkEvent: 2/2, PayloadReady: 2/2, EventTimings: 0/2, got NetMonitor:NetworkEvent for server0.conn125.netEvent47
[task 2021-07-07T21:37:12.510Z] 21:37:12     INFO - > Network event progress: NetworkEvent: 2/2, PayloadReady: 2/2, EventTimings: 1/2, got NetMonitor:NetworkEventUpdated:EventTimings for server0.conn125.netEvent27
[task 2021-07-07T21:37:12.511Z] 21:37:12     INFO - > Network event progress: NetworkEvent: 2/2, PayloadReady: 2/2, EventTimings: 2/2, got NetMonitor:NetworkEventUpdated:EventTimings for server0.conn125.netEvent47
[task 2021-07-07T21:37:12.511Z] 21:37:12     INFO - Buffered messages finished
[task 2021-07-07T21:37:12.515Z] 21:37:12     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_search-results.js | Node is not focusable via the accessibility API: id: /server0.conn125.netEvent27/0, tagName: TR, className: treeRow resultRow - 
[task 2021-07-07T21:37:12.515Z] 21:37:12     INFO - Stack trace:
[task 2021-07-07T21:37:12.515Z] 21:37:12     INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-07-07T21:37:12.515Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:265
[task 2021-07-07T21:37:12.515Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertFocusable:308
[task 2021-07-07T21:37:12.515Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:518
[task 2021-07-07T21:37:12.515Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:492
[task 2021-07-07T21:37:12.515Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:sendMouseEvent:222
[task 2021-07-07T21:37:12.516Z] 21:37:12     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_search-results.js:checkSearchResult:201
[task 2021-07-07T21:37:12.516Z] 21:37:12     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_search-results.js:null:87
[task 2021-07-07T21:37:12.516Z] 21:37:12     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1086
[task 2021-07-07T21:37:12.516Z] 21:37:12     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1126
[task 2021-07-07T21:37:12.516Z] 21:37:12     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:943
[task 2021-07-07T21:37:12.516Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2021-07-07T21:37:12.517Z] 21:37:12     INFO - GECKO(2944) | console.log: #headers-panel .url-preview .properties-view
[task 2021-07-07T21:37:12.518Z] 21:37:12     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_search-results.js | There should be 1 item displayed in this tabpanel - 
[task 2021-07-07T21:37:12.518Z] 21:37:12     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_search-results.js | Content must include test - 
[task 2021-07-07T21:37:12.519Z] 21:37:12     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-07-07T21:37:12.521Z] 21:37:12     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_search-results.js | Node is not focusable via the accessibility API: id: /server0.conn125.netEvent27/1, tagName: TR, className: treeRow resultRow - 
[task 2021-07-07T21:37:12.521Z] 21:37:12     INFO - Stack trace:
[task 2021-07-07T21:37:12.521Z] 21:37:12     INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-07-07T21:37:12.521Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:265
[task 2021-07-07T21:37:12.521Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertFocusable:308
[task 2021-07-07T21:37:12.522Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:518
[task 2021-07-07T21:37:12.522Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:492
[task 2021-07-07T21:37:12.522Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:sendMouseEvent:222
[task 2021-07-07T21:37:12.522Z] 21:37:12     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_search-results.js:checkSearchResult:201
[task 2021-07-07T21:37:12.522Z] 21:37:12     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_search-results.js:null:95
[task 2021-07-07T21:37:12.522Z] 21:37:12     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1086
[task 2021-07-07T21:37:12.522Z] 21:37:12     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1126
[task 2021-07-07T21:37:12.522Z] 21:37:12     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:943
[task 2021-07-07T21:37:12.522Z] 21:37:12     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2021-07-07T21:37:12.523Z] 21:37:12     INFO - GECKO(2944) | console.log: #headers-panel #responseHeaders .properties-view
[task 2021-07-07T21:37:12.524Z] 21:37:12     INFO - Console message: [JavaScript Warning: "Empty string passed to getElementById()." {file: "chrome://global/content/elements/browser-custom-element.js" line: 391}]
[task 2021-07-07T21:37:12.524Z] 21:37:12     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_search-results.js | There should be 1 item displayed in this tabpanel - 
[task 2021-07-07T21:37:12.525Z] 21:37:12     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_search-results.js | Content must include test - 
[task 2021-07-07T21:37:12.525Z] 21:37:12     INFO - Not taking screenshot here: see the one that was previously logged

Sebo, could you take a look at this frequent of the new test, please?

Flags: needinfo?(sebastianzartner)
Regressed by: 1713301
Has Regression Range: --- → yes

I hoped I fixed that with the last change to that test case. Unfortunately it's obviously still there. It's currently not possible for me to push to Try (see bug 1718995) and I cannot reproduce this locally so far.
I'll try to find the cause for this but maybe someone else can help out here. Honza, any idea what's causing this error?

Sebastian

Flags: needinfo?(sebastianzartner) → needinfo?(odvarko)

I think that the test has two issues:

  1. The XHR requests are not executed sequentially, but still in parallel
    I fixed that in the try push below (this fixes the test for me when running locally on Win and Linux)

  2. I am not sure why the test is using the AccessibilityUtils
    Removed in the try push below

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cdd1f88ca282af5c9a3a4dc673f726bb3f91c15

:marco, I am seeing that the accessibility checks have been enabled for the following job:
https://treeherder.mozilla.org/logviewer?job_id=344624525&repo=autoland&lineNumber=3715

Linux 18.04 x64 opt Mochitests with accessibility checks enabled test-linux1804-64/opt-mochitest-devtools-chrome-a11y-checks-e10s dt4

How can I enable it when pushing to try (for DevTools)

Honza

Flags: needinfo?(odvarko) → needinfo?(mcastelluccio)

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #4)

:marco, I am seeing that the accessibility checks have been enabled for the following job:
https://treeherder.mozilla.org/logviewer?job_id=344624525&repo=autoland&lineNumber=3715

Linux 18.04 x64 opt Mochitests with accessibility checks enabled test-linux1804-64/opt-mochitest-devtools-chrome-a11y-checks-e10s dt4

How can I enable it when pushing to try (for DevTools)

You should be able to select that specific suite by using "mach try fuzzy" and selecting the jobs from the list.

Flags: needinfo?(mcastelluccio)

New try with some test changes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=345b91dfa4e6ef5bd0a4cf06cd003297562e051f

We could try to use clickElement instead of EventUtils.sendMouseEvent({ type: "click" }) if the accessibility errors are still there.
https://searchfox.org/mozilla-central/rev/183b0cfc30f2d40f818a08cbea960f6119e2d196/devtools/client/netmonitor/test/head.js#1255-1257

Honza

There are 80 total failures in the last 7 days on

[task 2021-07-11T18:46:11.211Z] 18:46:11 INFO - TEST-START | devtools/client/netmonitor/test/browser_net_search-results.js
[task 2021-07-11T18:46:12.611Z] 18:46:12 INFO - TEST-INFO | started process screentopng
[task 2021-07-11T18:46:12.857Z] 18:46:12 INFO - TEST-INFO | screentopng: exit 0
[task 2021-07-11T18:46:12.859Z] 18:46:12 INFO - Buffered messages logged at 18:46:11
[task 2021-07-11T18:46:12.859Z] 18:46:12 INFO - Entering test bound
[task 2021-07-11T18:46:12.860Z] 18:46:12 INFO - Initializing a network monitor pane.
[task 2021-07-11T18:46:12.860Z] 18:46:12 INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/netmonitor/test/html_custom-get-page.html
[task 2021-07-11T18:46:12.861Z] 18:46:12 INFO - Tab added and finished loading
[task 2021-07-11T18:46:12.861Z] 18:46:12 INFO - Net tab added successfully: http://example.com/browser/devtools/client/netmonitor/test/html_custom-get-page.html
[task 2021-07-11T18:46:12.862Z] 18:46:12 INFO - Network monitor pane shown successfully.
[task 2021-07-11T18:46:12.864Z] 18:46:12 INFO - Disabling cache and reloading page.
[task 2021-07-11T18:46:12.866Z] 18:46:12 INFO - Got marker: dom-interactive
[task 2021-07-11T18:46:12.866Z] 18:46:12 INFO - Got marker: dom-complete
[task 2021-07-11T18:46:12.869Z] 18:46:12 INFO - Got two timeline markers, done waiting
[task 2021-07-11T18:46:12.870Z] 18:46:12 INFO - Buffered messages logged at 18:46:12
[task 2021-07-11T18:46:12.871Z] 18:46:12 INFO - > Network event progress: NetworkEvent: 0/1, PayloadReady: 1/1, EventTimings: 0/0, got NetMonitor:PayloadReady for server0.conn125.netEvent8
[task 2021-07-11T18:46:12.874Z] 18:46:12 INFO - > Network event progress: NetworkEvent: 1/1, PayloadReady: 1/1, EventTimings: 0/1, got NetMonitor:NetworkEvent for server0.conn125.netEvent8
[task 2021-07-11T18:46:12.876Z] 18:46:12 INFO - Console message: [JavaScript Warning: "Relative positioning of table rows and row groups is now supported. This site may need to be updated because it may depend on this feature having no effect." {file: "resource://devtools/client/netmonitor/src/components/request-list/RequestListHeader.js" line: 545}]
[task 2021-07-11T18:46:12.877Z] 18:46:12 INFO - > Network event progress: NetworkEvent: 1/1, PayloadReady: 1/1, EventTimings: 1/1, got NetMonitor:NetworkEventUpdated:EventTimings for server0.conn125.netEvent8
[task 2021-07-11T18:46:12.881Z] 18:46:12 INFO - Clearing requests in the UI.
[task 2021-07-11T18:46:12.882Z] 18:46:12 INFO - Starting test...
[task 2021-07-11T18:46:12.883Z] 18:46:12 INFO - Console message: [JavaScript Warning: "Cookie “name1” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "http://example.com/browser/devtools/client/netmonitor/test/sjs_search-test-server.sjs?value=test1" line: 0}]
[task 2021-07-11T18:46:12.884Z] 18:46:12 INFO - Console message: [JavaScript Warning: "Cookie “name1” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "http://example.com/browser/devtools/client/netmonitor/test/sjs_search-test-server.sjs?value=test1" line: 0}]
[task 2021-07-11T18:46:12.886Z] 18:46:12 INFO - Console message: [JavaScript Warning: "Cookie “name1” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "http://example.com/browser/devtools/client/netmonitor/test/sjs_search-test-server.sjs?value=test2" line: 0}]
[task 2021-07-11T18:46:12.888Z] 18:46:12 INFO - Console message: [JavaScript Warning: "Cookie “name1” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite" {file: "http://example.com/browser/devtools/client/netmonitor/test/sjs_search-test-server.sjs?value=test2" line: 0}]
[task 2021-07-11T18:46:12.889Z] 18:46:12 INFO - > Network event progress: NetworkEvent: 0/2, PayloadReady: 1/2, EventTimings: 0/0, got NetMonitor:PayloadReady for server0.conn125.netEvent27
[task 2021-07-11T18:46:12.890Z] 18:46:12 INFO - > Network event progress: NetworkEvent: 0/2, PayloadReady: 2/2, EventTimings: 0/0, got NetMonitor:PayloadReady for server0.conn125.netEvent46
[task 2021-07-11T18:46:12.893Z] 18:46:12 INFO - > Network event progress: NetworkEvent: 1/2, PayloadReady: 2/2, EventTimings: 0/1, got NetMonitor:NetworkEvent for server0.conn125.netEvent27
[task 2021-07-11T18:46:12.895Z] 18:46:12 INFO - > Network event progress: NetworkEvent: 2/2, PayloadReady: 2/2, EventTimings: 0/2, got NetMonitor:NetworkEvent for server0.conn125.netEvent46
[task 2021-07-11T18:46:12.896Z] 18:46:12 INFO - > Network event progress: NetworkEvent: 2/2, PayloadReady: 2/2, EventTimings: 1/2, got NetMonitor:NetworkEventUpdated:EventTimings for server0.conn125.netEvent27
[task 2021-07-11T18:46:12.898Z] 18:46:12 INFO - > Network event progress: NetworkEvent: 2/2, PayloadReady: 2/2, EventTimings: 2/2, got NetMonitor:NetworkEventUpdated:EventTimings for server0.conn125.netEvent46
[task 2021-07-11T18:46:12.899Z] 18:46:12 INFO - Buffered messages finished
[task 2021-07-11T18:46:12.902Z] 18:46:12 INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_search-results.js | Node is not focusable via the accessibility API: id: /server0.conn125.netEvent27/0, tagName: TR, className: treeRow resultRow -
[task 2021-07-11T18:46:12.903Z] 18:46:12 INFO - Stack trace:
[task 2021-07-11T18:46:12.904Z] 18:46:12 INFO - chrome://mochikit/content/browser-test.js:test_ok:1326
[task 2021-07-11T18:46:12.904Z] 18:46:12 INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:265
[task 2021-07-11T18:46:12.905Z] 18:46:12 INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertFocusable:308
[task 2021-07-11T18:46:12.906Z] 18:46:12 INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:518
[task 2021-07-11T18:46:12.907Z] 18:46:12 INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:492
[task 2021-07-11T18:46:12.908Z] 18:46:12 INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:sendMouseEvent:222
[task 2021-07-11T18:46:12.909Z] 18:46:12 INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_search-results.js:checkSearchResult:201
[task 2021-07-11T18:46:12.910Z] 18:46:12 INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_search-results.js:null:87
[task 2021-07-11T18:46:12.911Z] 18:46:12 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1081
[task 2021-07-11T18:46:12.912Z] 18:46:12 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1121
[task 2021-07-11T18:46:12.913Z] 18:46:12 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:938
[task 2021-07-11T18:46:12.915Z] 18:46:12 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2021-07-11T18:46:12.916Z] 18:46:12 INFO - GECKO(2685) | console.log: #headers-panel .url-preview .properties-view
[task 2021-07-11T18:46:12.917Z] 18:46:12 INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_search-results.js | There should be 1 item displayed in this tabpanel -
[task 2021-07-11T18:46:12.919Z] 18:46:12 INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_search-results.js | Content must include test -
[task 2021-07-11T18:46:12.920Z] 18:46:12 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-07-11T18:46:12.922Z] 18:46:12 INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_search-results.js | Node is not focusable via the accessibility API: id: /server0.conn125.netEvent27/1, tagName: TR, className: treeRow resultRow -

Whiteboard: [stockwell needswork:owner]
Summary: Intermittent [Tier 2] devtools/client/netmonitor/test/browser_net_search-results.js | Node is not focusable via the accessibility API: id: /server0.conn125.netEvent27/0, tagName: TR, className: treeRow resultRow - → Permanent [Tier 2] devtools/client/netmonitor/test/browser_net_search-results.js | Node is not focusable via the accessibility API: id: /server0.conn125.netEvent27/0, tagName: TR, className: treeRow resultRow -

Sebastian, the accessibility errors are still there. I think you can try to use clickElement instead of EventUtils.sendMouseEvent({ type: "click" })
(you can search DT code base for some examples, if needed)

We should fix this ASAP

Honza

Flags: needinfo?(sebastianzartner)

I've tried to fix that yesterday though got an error locally. I'll check it again later.

Sebastian

Removed the logic calling the AccessibilityUtils which should fix the accessibility failures.

The search matches are also clicked using clickElement() after being scrolled into view which fixes bug 1719585.

Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED

The attached patch is meant to fix both, this bug and bug 1719585. I've now changed the logic to use clickElement().
Honza, could you please do another Try push to see if it works as expected now?

Sebastian

Flags: needinfo?(sebastianzartner) → needinfo?(odvarko)
See Also: → 1719585

Thank you for working on this!

Here is the try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=312286bfe7b82c41d0711e732ea2598da67bab28

Also, I am seeing the following eslint error when applying the patch:

c:/src/mozilla.org/mozilla-central/devtools/client/netmonitor/test/browser_net_search-results.js
  32:44  error  Too many nested callbacks (4). Maximum allowed is 3.  max-nested-callbacks (eslint)
Flags: needinfo?(odvarko)

The Try push looks good and I fixed the ESLint error. So Honza, I think we're good to go. Please have a look at the patch again and let me know if there's still something missing.

Thanks in advance,

Sebastian

Flags: needinfo?(odvarko)
Attachment #9231059 - Attachment description: Bug 1719567 - Fixed test case devtools/client/netmonitor/test/browser_net_search-results.js. r=honza → Bug 1719567 - [devtools] Fixed test case devtools/client/netmonitor/test/browser_net_search-results.js. r=honza

Awesome!

Honza

Flags: needinfo?(odvarko)
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bbaf11c3d56
[devtools] Fixed test case devtools/client/netmonitor/test/browser_net_search-results.js. r=Honza
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

The patch landed in nightly and beta is affected.
:sebo, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(sebastianzartner)

I assume it's not important to uplift this to 91 as it's just a test case, though feel free to correct me.

Sebastian

Flags: needinfo?(sebastianzartner)

I was too hasty. Andreea just asked for uplifting in bug 1719585. My dear name twin, could you please do the uplift?

Sebastian

Flags: needinfo?(aryx.bugmail)

Comment on attachment 9231059 [details]
Bug 1719567 - [devtools] Fixed test case devtools/client/netmonitor/test/browser_net_search-results.js. r=honza

Beta/Release Uplift Approval Request

  • User impact if declined: Test failures for Firefox 91.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch fixes a failing test case.
  • String changes made/needed:
Attachment #9231059 - Flags: approval-mozilla-beta?

Comment on attachment 9231059 [details]
Bug 1719567 - [devtools] Fixed test case devtools/client/netmonitor/test/browser_net_search-results.js. r=honza

Thanks, I will uplift the change tomorrow. Because the patch only modifies a test and nothing which is part of the build, it doesn't need approval for uplift.

Flags: needinfo?(aryx.bugmail)
Attachment #9231059 - Flags: approval-mozilla-beta?

Ah, I see. Thank you for the info and for taking care of it!

Sebastian

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: