Address bar search cannot return results for both Bookmarks and Open tabs simultaneously.
Categories
(Firefox :: Address Bar, defect, P3)
Tracking
()
People
(Reporter: theherk, Assigned: daleharvey)
References
Details
(Keywords: papercut, Whiteboard: [snt-scrubbed][search-papercut])
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:89.0) Gecko/20100101 Firefox/89.0
Steps to reproduce:
Navigate to Settings > Search > Search Suggestions "Change settings for other address bar suggestions". Disable all address bar result types except leave "Bookmarks" and "Open tab" selected.
Add a bookmark. Open a tab (e.g. mozilla.org). Open a new tab, select the address bar. Begin to type bookmark (found), Begin to type "moz" (NOT found).
To verify, go back to settings and uncheck "Bookmarks" leaving "Open tabs" checked. Then, repeat. Open a new tab, and select address bar. Begin to type "moz" (found "switch to tab").
Actual results:
I am unable to search for both Bookmarks and Open tabs at the same time. With both options enabled only Bookmarks are returns unless "%" is added to the search string.
I have tested this on macOS Big Sur (Macbook Pro Intel) v89.0.2 and macOS Big Sur (Macbook Air M1) v88.0.1 with the same results.
Expected results:
Both matching Bookmarks and Open tabs should be returned.
|
||
Comment 1•5 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
Reporter | |
Comment 2•5 years ago
|
||
For posterity, community question is here: https://support.mozilla.org/en-US/questions/1343068.
|
||
Comment 3•5 years ago
•
|
||
It sounds like we are returning things that are bookmarks, or that are bookmarked open tabs, but that's not the intent of the UI, we should return bookmarks AND open tabs (regardless of their bookmarking status). Likely what happens is we filter out history results, and open tabs come from history. I can confirm the bug.
|
|
||
Updated•5 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
So we have taken a look at this and the steps that confirm this were misunderstood.
We deduplicate results in the muxer because we specifically do not want to return the exact same url in different groups, in the steps to reproduce we are using mozilla.org and only the switch to tab result returned which is expected.
|
|
Reporter | |
Comment 5•3 years ago
|
||
Fair enough Dale, but I'm not sure where the misunderstanding was. When I opened the bug, it behaved as described. It no longer does. You can now search both open tabs and bookmarks without issue, including open tabs that are not bookmarked. So it seems it was just fixed at some point; that was 25 versions back. Glad this is closed.
Description
•