Unify js::intl_availableMeasurementUnits in js/src/builtin/intl/NumberFormat.cpp
Categories
(Core :: Internationalization, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: gregtatum, Assigned: anba)
References
Details
(Whiteboard: [i18n-unification], [i18n-unification-help-wanted] )
Attachments
(2 files)
In Bug 1719732, there is some clean up work for relative time format. There is some additional code located in NumberFormat.cpp. After Bug 1719732 lands, this bug will serve to ensure all of the #include statements are cleaned up, and file any new bugs to handle that work.
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
Currently only provides a single method to retrieve all available measurement units.
MeasureUnit::GetAvailable() returns an enumeration similar to the other Intl
classes which use intl::Enumeration. This approach gives us a more consistent
API, because it abstracts away the internal ICU implementation, which looks up
the measurement units through UResourceBundle. But it also means the
implementation is slightly more complicated due to this additional abstraction.
The default constructor was deleted because all methods are static.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D125966
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/55a4f2cf06f4 Part 1: Add a MeasureUnit class to the unified Intl API. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/949781998bbf Part 2: Call MeasureUnit::GetAvailable() in SpiderMonkey. r=platform-i18n-reviewers,dminor
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/55a4f2cf06f4
https://hg.mozilla.org/mozilla-central/rev/949781998bbf
Description
•