Closed
Bug 1719758
Opened 3 years ago
Closed 3 years ago
Check all unwraps in TestPluralRules.cpp
Categories
(Core :: Internationalization, task, P3)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: nordzilla, Assigned: nordzilla)
References
Details
(Whiteboard: [i18n-unification])
Attachments
(1 file)
As we continue to discover potential differences in the behavior of ICU4X vs. ICU4C, we should ensure that our gtest suite doesn't break when encountering unexpected behavior.
This patch will change the TestPluralRules.cpp file to test all result values are OK before unwrapping them. Previously, values were unwrapped assuming they will be OK, but this crashes the test suite in the event that they are not.
Now tests will fail and report the failure instead of crashing.
|
Assignee | |
Comment 1•3 years ago
|
||
Modifies TestPluralRules.cpp to assert that all result values are okay
before unwrapping them. Previously the test suite would crash if an
error result was unwrapped. Now it will fail the test and report the
failure.
|
||
Updated•3 years ago
|
Attachment #9230388 -
Attachment description: WIP: Bug 1719758 - Test result values before unwrapping in TestPluralRules → Bug 1719758 - Test result values before unwrapping in TestPluralRules r=#platform-i18n-reviewers
Pushed by enordin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/329106017f97 Test result values before unwrapping in TestPluralRules r=platform-i18n-reviewers,dminor
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
|
|
Assignee | |
Updated•3 years ago
|
Whiteboard: [i18n-unification]
|
||
Updated•3 years ago
|
Priority: P4 → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•