Closed Bug 1719772 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 29616 - [LayoutNG] OOF inline containing block conversions

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29616 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29616
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] OOF inline containing block conversions

When we create the containing block rect based on the geometry
calculated in InlineContainingBlockUtils, we convert everything
against the entire containing block, including the block size from
all fragments. However, the start/end rects that are calculated
in InlineContainingBlockUtils are relative a single containing
block fragment.

As a result, we can end up with incorrect offsets when performing
writing mode conversions on the containing block rect. To fix this,
convert the item offsets in InlineContainingBlockUtils such that they
are relative to the full containing block instead.

Bug: 1227115
Change-Id: I1039ef0c93ef928891c3b581399b3d3f1427d6b5
Reviewed-on: https://chromium-review.googlesource.com/3017280
WPT-Export-Revision: 86cac583b1dc70ce4152b0a747ddc9c8800b6dad

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/out-of-flow-in-multicolumn-067.html: FAIL

New Tests That Don't Pass

/css/css-break/out-of-flow-in-multicolumn-066.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-break/out-of-flow-in-multicolumn-067.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68f8048a3ce9
[wpt PR 29616] - [LayoutNG] OOF inline containing block writing-mode conversions, a=testonly
https://hg.mozilla.org/integration/autoland/rev/982d1ecd2d01
[wpt PR 29616] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2aae8e0c6370
[wpt PR 29616] - [LayoutNG] OOF inline containing block writing-mode conversions, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e46e51e1234b
[wpt PR 29616] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.