1719835 - Permanent devtools/client/webconsole/test/browser/browser_webconsole_stubs_page_error.js | "Promise reject Error Object with error cause" packet has expected value when Gecko 91 merges to Beta on 2021-07-12

Status: VERIFIED FIXED

(DevTools :: Shared Components, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log

[task 2021-07-09T10:57:54.033Z] 10:57:54     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_stubs_page_error.js | "Promise reject Error Object with custom name" packet has expected value - 
[task 2021-07-09T10:57:54.034Z] 10:57:54     INFO - Buffered messages finished
[task 2021-07-09T10:57:54.070Z] 10:57:54     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_stubs_page_error.js | "Promise reject Error Object with error cause" packet has expected value - Got "{\n  \"isAlreadyExistingResource\": false,\n  \"pageError\": {\n    \"category\": \"content javascript\",\n    \"chromeContext\": false,\n    \"columnNumber\": 15,\n    \"error\": true,\n    \"errorMessage\": \"Error: something went wrong\",\n    \"errorMessageName\": \"\",\n    \"exception\": {\n      \"_grip\": {\n        \"type\": \"object\",\n        \"actor\": \"XXX\",\n        \"class\": \"Error\",\n        \"ownPropertyLength\": 5,\n        \"extensible\": true,\n        \"frozen\": false,\n        \"sealed\": false,\n        \"isError\": true,\n        \"preview\": {\n          \"kind\": \"Error\",\n          \"name\": \"Error\",\n          \"message\": \"something went wrong\",\n          \"stack\": \"@http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html:5:15\\npromise callback*@http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html:1:19\\n\",\n          \"fileName\": \"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html\",\n          \"lineNumber\": 5,\n          \"columnNumber\": 15,\n          \"cause\": {\n            \"type\": \"object\",\n            \"actor\": \"XXX\",\n            \"class\": \"TypeError\",\n            \"ownPropertyLength\": 4,\n            \"extensible\": true,\n            \"frozen\": false,\n            \"sealed\": false,\n            \"isError\": true,\n            \"preview\": {\n              \"kind\": \"Error\",\n              \"name\": \"TypeError\",\n              \"message\": \"a.b is undefined\",\n              \"stack\": \"@http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html:3:9\\npromise callback*@http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html:1:19\\n\",\n              \"fileName\": \"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html\",\n              \"lineNumber\": 3,\n              \"columnNumber\": 9\n            }\n          }\n        }\n      },\n      \"actorID\": \"XXX\"\n    },\n    \"hasException\": true,\n    \"info\": false,\n    \"innerWindowID\": 2147483651,\n    \"isForwardedFromContentProcess\": false,\n    \"isPromiseRejection\": true,\n    \"lineNumber\": 5,\n    \"lineText\": \"\",\n    \"notes\": null,\n    \"private\": false,\n    \"sourceId\": \"XXX\",\n    \"sourceName\": \"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html\",\n    \"stacktrace\": [\n      {\n        \"filename\": \"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html\",\n        \"sourceId\": null,\n        \"lineNumber\": 5,\n        \"columnNumber\": 15,\n        \"functionName\": null\n      },\n      {\n        \"filename\": \"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html\",\n        \"sourceId\": null,\n        \"lineNumber\": 1,\n        \"columnNumber\": 19,\n        \"functionName\": null,\n        \"asyncCause\": \"promise callback\"\n      },\n      {\n        \"filename\": \"resource://testing-common/content-task.js line 110 > eval\",\n        \"sourceId\": null,\n        \"lineNumber\": 6,\n        \"columnNumber\": 29,\n        \"functionName\": null\n      },\n      {\n        \"filename\": \"resource://testing-common/content-task.js\",\n        \"sourceId\": null,\n        \"lineNumber\": 111,\n        \"columnNumber\": 33,\n        \"functionName\": null\n      },\n      {\n        \"filename\": \"resource://testing-common/content-task.js\",\n        \"sourceId\": null,\n        \"lineNumber\": 64,\n        \"columnNumber\": 19,\n        \"functionName\": null,\n        \"asyncCause\": \"MessageListener.receiveMessage\"\n      }\n    ],\n    \"timeStamp\": 1572867483805,\n    \"warning\": false\n  },\n  \"resourceType\": \"error-message\"\n}", expected "{\n  \"isAlreadyExistingResource\": false,\n  \"pageError\": {\n    \"category\": \"content javascript\",\n    \"chromeContext\": false,\n    \"columnNumber\": 15,\n    \"error\": true,\n    \"errorMessage\": \"Error: something went wrong\",\n    \"errorMessageName\": \"\",\n    \"exception\": {\n      \"_grip\": {\n        \"type\": \"object\",\n        \"actor\": \"XXX\",\n        \"class\": \"Error\",\n        \"ownPropertyLength\": 5,\n        \"extensible\": true,\n        \"frozen\": false,\n        \"sealed\": false,\n        \"isError\": true,\n        \"preview\": {\n          \"kind\": \"Error\",\n          \"name\": \"Error\",\n          \"message\": \"something went wrong\",\n          \"stack\": \"@http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html:5:15\\npromise callback*@http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html:1:19\\n\",\n          \"fileName\": \"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html\",\n          \"lineNumber\": 5,\n          \"columnNumber\": 15,\n          \"cause\": {\n            \"type\": \"object\",\n            \"actor\": \"XXX\",\n            \"class\": \"TypeError\",\n            \"ownPropertyLength\": 4,\n            \"extensible\": true,\n            \"frozen\": false,\n            \"sealed\": false,\n            \"isError\": true,\n            \"preview\": {\n              \"kind\": \"Error\",\n              \"name\": \"TypeError\",\n              \"message\": \"can't access property \\\"c\\\", a.b is undefined\",\n              \"stack\": \"@http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html:3:9\\npromise callback*@http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html:1:19\\n\",\n              \"fileName\": \"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html\",\n              \"lineNumber\": 3,\n              \"columnNumber\": 9\n            }\n          }\n        }\n      },\n      \"actorID\": \"XXX\"\n    },\n    \"hasException\": true,\n    \"info\": false,\n    \"innerWindowID\": 2147483651,\n    \"isForwardedFromContentProcess\": false,\n    \"isPromiseRejection\": true,\n    \"lineNumber\": 5,\n    \"lineText\": \"\",\n    \"notes\": null,\n    \"private\": false,\n    \"sourceId\": \"XXX\",\n    \"sourceName\": \"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html\",\n    \"stacktrace\": [\n      {\n        \"filename\": \"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html\",\n        \"sourceId\": null,\n        \"lineNumber\": 5,\n        \"columnNumber\": 15,\n        \"functionName\": null\n      },\n      {\n        \"filename\": \"http://example.com/browser/devtools/client/webconsole/test/browser/test-console-api.html\",\n        \"sourceId\": null,\n        \"lineNumber\": 1,\n        \"columnNumber\": 19,\n        \"functionName\": null,\n        \"asyncCause\": \"promise callback\"\n      },\n      {\n        \"filename\": \"resource://testing-common/content-task.js line 110 > eval\",\n        \"sourceId\": null,\n        \"lineNumber\": 6,\n        \"columnNumber\": 29,\n        \"functionName\": null\n      },\n      {\n        \"filename\": \"resource://testing-common/content-task.js\",\n        \"sourceId\": null,\n        \"lineNumber\": 111,\n        \"columnNumber\": 33,\n        \"functionName\": null\n      },\n      {\n        \"filename\": \"resource://testing-common/content-task.js\",\n        \"sourceId\": null,\n        \"lineNumber\": 64,\n        \"columnNumber\": 19,\n        \"functionName\": null,\n        \"asyncCause\": \"MessageListener.receiveMessage\"\n      }\n    ],\n    \"timeStamp\": 1572867483805,\n    \"warning\": false\n  },\n  \"resourceType\": \"error-message\"\n}"
[task 2021-07-09T10:57:54.070Z] 10:57:54     INFO - Stack trace:
[task 2021-07-09T10:57:54.070Z] 10:57:54     INFO - chrome://mochikit/content/browser-test.js:test_is:1359
[task 2021-07-09T10:57:54.070Z] 10:57:54     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_stubs_page_error.js:null:54
[task 2021-07-09T10:57:54.070Z] 10:57:54     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1086
[task 2021-07-09T10:57:54.070Z] 10:57:54     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1126
[task 2021-07-09T10:57:54.070Z] 10:57:54     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:943
[task 2021-07-09T10:57:54.070Z] 10:57:54     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2021-07-09T10:57:54.071Z] 10:57:54     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-07-09T10:57:54.077Z] 10:57:54     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_stubs_page_error.js | The pageError stubs file needs to be updated by running `mach test devtools/client/webconsole/test/browser/browser_webconsole_stubs_page_error.js --headless --setenv WEBCONSOLE_STUBS_UPDATE=true` - 
[task 2021-07-09T10:57:54.077Z] 10:57:54     INFO - Stack trace:
[task 2021-07-09T10:57:54.077Z] 10:57:54     INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-07-09T10:57:54.077Z] 10:57:54     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_stubs_page_error.js:null:59
[task 2021-07-09T10:57:54.077Z] 10:57:54     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1086
[task 2021-07-09T10:57:54.077Z] 10:57:54     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1126
[task 2021-07-09T10:57:54.077Z] 10:57:54     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:943
[task 2021-07-09T10:57:54.077Z] 10:57:54     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041
[task 2021-07-09T10:57:54.077Z] 10:57:54     INFO - Leaving test bound 

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1719835 - [devtools] Fix beta simulation perma fail on browser_webconsole_stubs_page_error.js. r=bomsy.

The error message seems to be different in Nighly and Beta,
but I wasn't able to find any pref that is driving this.
Since the error message itself isn't super relevant, and given
that we're at the end of the cycle, this patch is only modifying
the expression so we get a different error.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The difference is controlled by the pref javascript.options.property_error_message_fix.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69872e47dc73
[devtools] Fix beta simulation perma fail on browser_webconsole_stubs_page_error.js. r=bomsy.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/69872e47dc73

Comment 5

[Alexandru Michis [:malexandru]]

Verified fixed in today's central-as-early-beta sim.