Closed Bug 1719849 Opened 3 years ago Closed 3 years ago

Windows "error: undefined symbol: public: __cdecl mozilla::mscom::ProcessRuntime::ProcessRuntime" bustage with --disable-accessibility

Categories

(Core :: IPC: MSCOM, defect)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox89 --- unaffected
firefox90 --- unaffected
firefox91 --- wontfix
firefox92 --- fixed

People

(Reporter: RyanVM, Assigned: alexical)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

lld-link: error: undefined symbol: public: __cdecl mozilla::mscom::ProcessRuntime::ProcessRuntime(enum mozilla::mscom::ProcessRuntime::ProcessCategory)
>>> referenced by C:/Users/Ryan/repos/mozilla/mozglue/misc/PreXULSkeletonUI.cpp
>>>               ..\misc\PreXULSkeletonUI.obj
Flags: needinfo?(dothayer)

Originally these includes were wrapped in an ACCESSIBILITY define because the
bug that manifested only affected screen readers. However, theoretically
speaking other things could cause us to initialize COM early and run into
troubles, so this is not strictly an a11y issue from that perspective. It
wasn't wrapped around ACCESSIBILITY defines inside PreXULSkeletonUI.cpp for
this reason, but there was still lingering inconsistency inside the moz.build
file. This corrects that.

Assignee: nobody → dothayer
Status: NEW → ASSIGNED
Attachment #9230522 - Attachment description: Bug 1719849 - Include ProcessRuntime.cpp and friends if not SM build r?RyanVM → Bug 1719849 - Include ProcessRuntime.cpp and friends if not SM build r?Jamie
Attachment #9230522 - Attachment description: Bug 1719849 - Include ProcessRuntime.cpp and friends if not SM build r?Jamie → Bug 1719849 - Include ProcessRuntime.cpp and friends if not SM build r?aklotz
Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f1b7a0cc0d3
Include ProcessRuntime.cpp and friends if not SM build r=aklotz
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Regressions: 1722515
Flags: needinfo?(dothayer)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: